Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous iam.py docstring updates #2251

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Oct 9, 2024

  • Closes Miscellaneous iam.py docstring updates #2250
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR resolves issues listed in #2250

pvlib/iam.py Outdated Show resolved Hide resolved
@kandersolar kandersolar added this to the v0.11.2 milestone Oct 10, 2024
Copy link
Contributor

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's a pleasure to announce that iam.py now is PEP8 compliant :)

pvlib/iam.py Outdated Show resolved Hide resolved
pvlib/iam.py Outdated Show resolved Hide resolved
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
@RDaxini
Copy link
Contributor Author

RDaxini commented Oct 15, 2024

Do we need a whatsnew entry?

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RDaxini and @echedey-ls!

@kandersolar kandersolar merged commit d9acdba into pvlib:main Oct 15, 2024
26 checks passed
@RDaxini RDaxini deleted the iam_docstring branch October 15, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miscellaneous iam.py docstring updates
4 participants