Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Removes LGTM Badges from README.md #1651

Merged
merged 6 commits into from
Feb 1, 2023
Merged

Conversation

ooprathamm
Copy link
Contributor

@ooprathamm ooprathamm commented Jan 27, 2023

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@ooprathamm
Copy link
Contributor Author

@mikofski this PR removes code quality row (containing LGTM badges) as requested by you

@AdamRJensen
Copy link
Member

Just wanted to note that this is related to GitHub retiring LGTM (see #1550 for further details).

Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ooprathamm

Could you also remove the line "exclude .lgtm.yml" in the file "MANIFEST.in" and the file .lgtm.yml.

@mikofski
Copy link
Member

mikofski commented Jan 27, 2023

@ooprathamm a few more tasks to close this out:

  • remove the line exclude .lgtm.yml in the file "MANIFEST.in"
  • remove the file .lgtm.yml.
  • add a note under documentation and add your name to contributors in what's new for 0.9.5

@ooprathamm
Copy link
Contributor Author

@mikofski made the changes asked by you.

@mikofski mikofski added documentation build tools Pipelines, CI, GH actions labels Jan 28, 2023
@kandersolar kandersolar merged commit 25af865 into pvlib:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build tools Pipelines, CI, GH actions documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants