-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from LGTM to GitHub code scanning #1550
Comments
As described above, a PR has been made by GitHub #1600. |
I'm not convinced that LGTM/GitHub code scanning is particularly useful for us. Security vulnerability analysis doesn't seem relevant for pvlib (to me, anyway), and I think its other functionality (linting, static analysis) is redundant with our other CI checks. I'm also not excited about curating the list of "dismissed alerts". If it were me I would probably get rid of it for this repository. But I also haven't looked into it very much and would be happy to learn I am overlooking some nice aspects :) |
Just as a comment, many of the issues that were flagged by LGTM were recently fixed in #1559. They were all rather minor, but nice to fix anyhow. |
For reference #554 added the LGTM badges. I liked them at the time because they showed that pvlib's code quality was very good and it did find a couple of minor bugs. I've been less than enthusiastic about it since then. I don't have a preference on this, just wanted to point to that context. |
Closing the PR and issue related to adding GitHub code scanning due to lack of interest from maintainers. |
Describe the bug
On pvlib's GitHub landing page (readme file), there's a shield/link to LGTM. While following this link, I noticed the following warning message:
So sometime before December, we should address this issue by either:
Upon reading the blog post linked in the message, it seems that the best option might be to just wait:
The text was updated successfully, but these errors were encountered: