-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update irradiance.reindl docs #2193
Conversation
I have personally never used "BHI" before but I did swap out the I_hb and I_h since BHI/GHI etc are what are in the pvlib user guide. The original equation also already used "DHI", so it's consistent with the variable naming style. Overally, I think I probably lean towards using shorter symbols instead, like I_xx, but I see how DHI/GHI etc is easier to understand so I think it would help to hear other views on this. |
Marked as draft until #2191 has been addressed to avoid duplicate reviews due to similarities between the changes made in these PRs |
consistent reference style
add date to sentence
Thanks for the review Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
as per the paper (variable I_on)
…-python into update_reindl_docs
Thanks @RDaxini! |
haydavies
#2183, related to Klucher diffuse sky docstring inconsistency #1405docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Docs here