Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update irradiance.reindl docs #2193

Merged
merged 14 commits into from
Oct 4, 2024
Merged

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Aug 30, 2024

Docs here

@RDaxini
Copy link
Contributor Author

RDaxini commented Aug 30, 2024

I have personally never used "BHI" before but I did swap out the I_hb and I_h since BHI/GHI etc are what are in the pvlib user guide. The original equation also already used "DHI", so it's consistent with the variable naming style. Overally, I think I probably lean towards using shorter symbols instead, like I_xx, but I see how DHI/GHI etc is easier to understand so I think it would help to hear other views on this.
This also relates to PRs #2191 and #2192

@RDaxini RDaxini marked this pull request as ready for review August 30, 2024 18:03
@RDaxini
Copy link
Contributor Author

RDaxini commented Sep 3, 2024

Marked as draft until #2191 has been addressed to avoid duplicate reviews due to similarities between the changes made in these PRs

@RDaxini RDaxini marked this pull request as draft September 3, 2024 09:02
@RDaxini RDaxini marked this pull request as ready for review September 25, 2024 18:11
@RDaxini RDaxini marked this pull request as draft September 25, 2024 18:11
@RDaxini RDaxini marked this pull request as ready for review September 25, 2024 18:55
@RDaxini RDaxini mentioned this pull request Sep 26, 2024
6 tasks
docs/sphinx/source/whatsnew/v0.11.2.rst Outdated Show resolved Hide resolved
pvlib/irradiance.py Outdated Show resolved Hide resolved
pvlib/irradiance.py Outdated Show resolved Hide resolved
pvlib/irradiance.py Outdated Show resolved Hide resolved
pvlib/irradiance.py Outdated Show resolved Hide resolved
@kandersolar kandersolar added this to the v0.11.2 milestone Oct 4, 2024
@AdamRJensen AdamRJensen merged commit 8767004 into pvlib:main Oct 4, 2024
26 of 27 checks passed
@AdamRJensen
Copy link
Member

Thanks @RDaxini!

@RDaxini RDaxini deleted the update_reindl_docs branch October 4, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Descriptions for Formula Components in haydavies
4 participants