-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Klucher diffuse sky docstring inconsistency #1405
Comments
I'm sure that Loutzenhiser's notation is To do with this: add inline citations, punctuation, units in brackets, define Maybe jettison the whole second paragraph that reiterates the inputs, and incorrectly adds To discuss: remove "must be >=0", or change to "should be >=0". The code doesn't require this restriction, although the model certainly isn't valid outside that range. My view: model constraints on input (should be's) would be better placed in the description or in Notes, and code restrictions (must be's) in the parameter descriptions. |
Seems like several of those items apply to the other sky diffuse model docstrings as well. Also, does it make sense for the Loutzenhiser reference to be listed first? Seems like it ought to be a secondary reference if it's included at all. |
Although Loutzenhiser is a survey and comparison among models, it more clearly defines several models than do the source papers. That's why we chose it as the baseline reference. |
The equation for F' should contain DHI rather than Id0.
Versions:
pvlib.__version__
: 0.9 and earlierThe text was updated successfully, but these errors were encountered: