Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toctree locations for backreferences #1630

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Fix toctree locations for backreferences #1630

merged 1 commit into from
Feb 1, 2023

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Jan 7, 2023 •
edited
Loading

@kandersolar kandersolar added this to the 0.9.5 milestone Jan 7, 2023
@kandersolar kandersolar marked this pull request as ready for review January 7, 2023 22:52
@kandersolar
Copy link
Member Author

@adriesse I think this solves the issue you noticed in #1602 (comment). Can you take a look and confirm?

AdamRJensen
AdamRJensen approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that it works. As an example, I posted screenshots of the pvlib.pvarray.fit_pvefficiency_adr function below.

Before

image

After

image

@AdamRJensen AdamRJensen merged commit e7531b2 into pvlib:main Feb 1, 2023
@kandersolar kandersolar deleted the docsfix branch February 1, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamRJensen AdamRJensen AdamRJensen approved these changes

Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
0.9.5
Development

Successfully merging this pull request may close these issues.
2 participants
@kandersolar @AdamRJensen