Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated pvlib.iotools.read_srml_month_from_solardat function #1989

Merged
merged 10 commits into from
Jun 6, 2024
Merged

Remove deprecated pvlib.iotools.read_srml_month_from_solardat function #1989

merged 10 commits into from
Jun 6, 2024

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Mar 12, 2024 •
edited
Loading

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The pvlib.iotools.read_srml_month_from_solardat function was deprecated in 0.10.0 and should be removed in 0.11.0.

@AdamRJensen AdamRJensen added io remote-data triggers --remote-data pytests labels Mar 12, 2024
@AdamRJensen AdamRJensen added this to the 0.11.0 milestone Mar 12, 2024
@AdamRJensen AdamRJensen mentioned this pull request Mar 12, 2024
Closed
8 tasks
@AdamRJensen AdamRJensen mentioned this pull request May 24, 2024
Closed
5 tasks
@AdamRJensen AdamRJensen added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels May 24, 2024
@AdamRJensen AdamRJensen marked this pull request as ready for review May 24, 2024 08:44
@AdamRJensen
Copy link
Member Author

@echedey-ls Would you be up for reviewing this PR?

echedey-ls
echedey-ls approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

Surprisingly, adding a :py:func:... with parenthesis doesn't mess the docs.

Some overly-nitpicky comments below, feel free to ignore them.

docs/sphinx/source/whatsnew/v0.11.0.rst Outdated Show resolved Hide resolved
pvlib/iotools/srml.py Outdated Show resolved Hide resolved
pvlib/tests/iotools/test_srml.py Outdated Show resolved Hide resolved
AdamRJensen and others added 2 commits June 4, 2024 13:48
@AdamRJensen @echedey-ls
Update docs/sphinx/source/whatsnew/v0.11.0.rst
b437c82 
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
@AdamRJensen
Implement code review changes
98de650
@AdamRJensen
Copy link
Member Author

AdamRJensen commented Jun 4, 2024 •
edited
Loading

Thank you very much for the review @echedey-ls

I'll merge this on June 6th if no one objects.

@AdamRJensen AdamRJensen merged commit 77c2051 into pvlib:main Jun 6, 2024
30 checks passed
@AdamRJensen AdamRJensen deleted the remove_read_srml_month_from_solardat branch June 6, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echedey-ls echedey-ls echedey-ls approved these changes

Assignees
No one assigned
Labels
io remote-data triggers --remote-data pytests
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamRJensen @echedey-ls