Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASV: bump numpy and pandas versions to match new requirements #1987

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Mar 11, 2024

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • [ ] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Follow-up to #1969; copying our new dependency minimum requirements to the asv benchmarks configuration.

@kandersolar kandersolar added this to the v0.10.4 milestone Mar 11, 2024
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JK I don't approve given the obvious install conflicts...

@kandersolar kandersolar marked this pull request as ready for review March 11, 2024 21:25
@kandersolar
Copy link
Member Author

I guess the reason that numpy==1.17.3 pandas==1.3.0 installs fine in the test CI jobs but I had to increase to numpy==1.17.5 to get it working here is because of some conda vs pypi difference. The ASV job uses conda for those deps while the test jobs install from pypi.

I doubt the differences will matter for the benchmarks, so for practicality I'm willing to accept a "not exactly minimum" version here.

Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I approve

@kandersolar kandersolar merged commit 407687f into pvlib:main Mar 12, 2024
34 checks passed
@kandersolar kandersolar deleted the benchmarks-min-reqs branch March 12, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants