-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gallery example for OEDI system 9068 #1985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expose the other loss parameters:
# Other loss types are left at their default amounts.
losses_parameters = dict(shading=0, availability=0)
Otherwise things look good to me.
I have my doubts if applying a transient operation on the module temperature makes this any more accurate when you use satellite data?
Maybe add a note about why you're not using the measured irradiance (I think that would be useful for people)
A shame that this great data initiative has so poor metadata - a bit ironic really.
5-minute PSM3 data is very "spiky", so using a transient model at least makes the modeled Tcell more realistic/smooth, if not also more accurate. IMHO it's reasonable to include by default unless we know for some reason that it makes results worse. I think SAM applies it by default for any dataset with time step below 20 minutes.
It does say this before fetching the weather dataset:
|
It could actually be instructive to use that measured data in the example anyway. |
[ ] Tests added[ ] Updates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data
) and Milestone are assigned to the Pull Request and linked Issue.