Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery example for OEDI system 9068 #1985

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Mar 7, 2024

@kandersolar kandersolar added this to the v0.10.4 milestone Mar 7, 2024
@kandersolar kandersolar marked this pull request as ready for review March 8, 2024 15:06
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expose the other loss parameters:

    # Other loss types are left at their default amounts.
    losses_parameters = dict(shading=0, availability=0)

Otherwise things look good to me.
image

I have my doubts if applying a transient operation on the module temperature makes this any more accurate when you use satellite data?

Maybe add a note about why you're not using the measured irradiance (I think that would be useful for people)

A shame that this great data initiative has so poor metadata - a bit ironic really.

@kandersolar
Copy link
Member Author

I have my doubts if applying a transient operation on the module temperature makes this any more accurate when you use satellite data?

5-minute PSM3 data is very "spiky", so using a transient model at least makes the modeled Tcell more realistic/smooth, if not also more accurate. IMHO it's reasonable to include by default unless we know for some reason that it makes results worse. I think SAM applies it by default for any dataset with time step below 20 minutes.

Maybe add a note about why you're not using the measured irradiance (I think that would be useful for people)

It does say this before fetching the weather dataset:

The system does have measured plane-of-array irradiance data, but the measurements suffer from row-to-row shading and tracker stalls. In this example, we will use weather data taken from the NSRDB PSM3 for the year 2019.

@adriesse
Copy link
Member

adriesse commented Mar 13, 2024

The system does have measured plane-of-array irradiance data, but the measurements suffer from row-to-row shading and tracker stalls. In this example, we will use weather data taken from the NSRDB PSM3 for the year 2019.

It could actually be instructive to use that measured data in the example anyway.

@kandersolar kandersolar merged commit c90cb4e into pvlib:main Mar 18, 2024
33 of 34 checks passed
@kandersolar kandersolar deleted the oedi-9068 branch March 18, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants