-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in plot_oedi_9068.py #1996
Conversation
* add example script and static plot images * configure sphinx-gallery to not execute this one * lint * whatsnew * fix backticks issue * updates from review
From a quick glance, failed tests have nothing to do with changes introduced by this PR. |
I can't reproduce this test error on my Windows system with scipy 1.12 and numpy 1.26.4. There were some changes to scipy's |
#2002 should be addressed now too, however on the built docs I'm pretty sure it won't show. Locally it does. I expect ReadTheDocs to apply some caching between runs at least for PR builds. See this issue of sphinx-gallery. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect ReadTheDocs to apply some caching between runs at least for PR builds.
I think this is not the case; to my knowledge, all builds are started from a blank slate every time. The only caching I experience with RTD is from my own web browser, and a hard refresh (ctrl-F5 or similar) has always fixed it :)
You are right, I never thought there would be a difference between that reloading shortcut and the common Ctrl+R. Btw, at least on Firefox Ctrl+Shift+R seems to do a hard reload too. PR should be ready to merge I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @echedey-ls!
plot_oedi_9068.py
#2002 and fixes a typo in the code[ ] Tests added[ ] Updates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Solve a typo in said file. View conversation.
Docs