Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in plot_oedi_9068.py #1996

Merged
merged 14 commits into from
Apr 3, 2024
Merged

Typo in plot_oedi_9068.py #1996

merged 14 commits into from
Apr 3, 2024

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented Mar 21, 2024

  • Closes Add thumbnail to plot_oedi_9068.py #2002 and fixes a typo in the code
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Solve a typo in said file. View conversation.

Docs

echedey-ls referenced this pull request Mar 21, 2024
* add example script and static plot images

* configure sphinx-gallery to not execute this one

* lint

* whatsnew

* fix backticks issue

* updates from review
@echedey-ls
Copy link
Contributor Author

echedey-ls commented Mar 21, 2024

From a quick glance, failed tests have nothing to do with changes introduced by this PR.

@kandersolar kandersolar added this to the v0.10.5 milestone Mar 21, 2024
@cwhanse
Copy link
Member

cwhanse commented Mar 26, 2024

From a quick glance, failed tests have nothing to do with changes introduced by this PR.

I can't reproduce this test error on my Windows system with scipy 1.12 and numpy 1.26.4. There were some changes to scipy's lambertw implementation for scipy 1.12 but I can't see that those changes would affect the values for that failed test. I don't know how to look to see if there's some Windows library that is different for scipy 1.10 vs. 1.12.

@echedey-ls
Copy link
Contributor Author

#2002 should be addressed now too, however on the built docs I'm pretty sure it won't show. Locally it does. I expect ReadTheDocs to apply some caching between runs at least for PR builds.

See this issue of sphinx-gallery.

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect ReadTheDocs to apply some caching between runs at least for PR builds.

I think this is not the case; to my knowledge, all builds are started from a blank slate every time. The only caching I experience with RTD is from my own web browser, and a hard refresh (ctrl-F5 or similar) has always fixed it :)

docs/examples/system-models/plot_oedi_9068.py Outdated Show resolved Hide resolved
@echedey-ls
Copy link
Contributor Author

I think this is not the case

You are right, I never thought there would be a difference between that reloading shortcut and the common Ctrl+R. Btw, at least on Firefox Ctrl+Shift+R seems to do a hard reload too.

PR should be ready to merge I think.

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @echedey-ls!

@kandersolar kandersolar merged commit ccf74ea into pvlib:main Apr 3, 2024
30 of 34 checks passed
@echedey-ls echedey-ls deleted the pr1985-typofix branch April 3, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add thumbnail to plot_oedi_9068.py
3 participants