Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More docs build fixes #2030

Merged
merged 10 commits into from
May 1, 2024
Merged

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented May 1, 2024

  • Partially addresses warnings in Docs improvements tracker and ReadTheDocs warnings #1983
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

I just got fed up of looking for "CRITICAL", "ERROR" and "WARNING" on the sphinx output and seeing so much noise. This PR clean ups the log - and most importantly, fixes some rendering issues.

Let's wait for the built docs and I will link all the affected pages.

@echedey-ls
Copy link
Contributor Author

echedey-ls commented May 1, 2024

Item Stable page PR page
pvlib.pvarray.huld Link Link
Snow index Link Link
SDM Models Index Link Link
Scaling Index Link Link
Deprecated pvlib.iotools.read_srml_month_from_solardat Link Link
bishop88_i_from_v Link Link
bishop88_mpp Link Link
bishop88_v_from_i Link Link
WhatsNew v0.3.0 Link Link
WhatsNew v0.9.1 Link Link

@echedey-ls
Copy link
Contributor Author

echedey-ls commented May 1, 2024

Ready for reviewing 😃

CC: @kandersolar , @cwhanse , ...

@cwhanse cwhanse added this to the v0.10.5 milestone May 1, 2024
@kandersolar kandersolar merged commit 345b26f into pvlib:main May 1, 2024
33 of 35 checks passed
@echedey-ls echedey-ls deleted the more-docs-build-fixes branch May 3, 2024 00:34
echedey-ls added a commit to echedey-ls/pvlib-python that referenced this pull request May 22, 2024
* broken references in old whatsnews

* add missing ref to bishop88_* funcs

* this was interpreted as code (?)

* I think this messes up the indentation

* Fix unknown references in autosummaries

* This one too

* 🚀

* Undo calcparams_cec, I misread

* Aha, this is the right calcparams_ function

* Dammit, it's always the linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants