Get the asv benchmarking job working again #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another idea is to use
|
|
I considered micromamba, but the version of asv we use doesn't support it. It might be possible to switch to mamba when we eventually update to a newer version of asv, but that's a bigger job than what I am willing to take on here. |
Closed
|
Merging without review due to this being a "maintain the status quo" PR to fix a minor CI job. |
echedey-ls
pushed a commit
to echedey-ls/pvlib-python
that referenced
this pull request
May 22, 2024
install an older version of conda in ASV CI job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.Continuing my push to get the CI back to all green checkmarks. The ASV job has been failing for a few weeks because the latest versions of conda renamed a certain option that asv uses to create the benchmarking environments. This PR ensures that a compatible version of conda is installed and available for asv's use. It's not really ideal to pin an older version of conda, but I don't see any real harm given that we're already pinning an older version of asv. We can just remove it when we eventually update to a newer version of asv.