Release 0.11.0 #456
Merged
Release 0.11.0 #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* �Add condition for PerformInteraction tertiaryText * Add choiceSecondaryImage to capabilities
* Add changes to handle interactionLayout parameter * Fix bounds for tiled secondary image * Add changes to display PI interactionText * Address review comments * Add fix to handle case with choiceID 0 * Apply suggestions from code review Co-authored-by: Collin <iCollin@users.noreply.github.com> Co-authored-by: Collin <iCollin@users.noreply.github.com>
* Add padding to Alert softbuttons and adjust size * Add restrictions to dynamic images and subtle alerts
* Reset audioStreamingIndicator to PLAY_PAUSE if undefined in request * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Reset audiostreamingindicator to PLAY_PAUSE on HMI_NONE Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Add interfaceName parameter to OnResetTimeout RPCFactory function * Fix appID typo in OnResetTimeout call
limit sending OnUpdateSubMenu to once per menu opening
* implement scrollable message * send onbutton press for all scrollable message soft buttons * address review comments * make cancel interaction work on apps other than the activeApp * use case block to avoid numbering state var
* Add keyboard autocomplete list and limited character list * Fix limited character list * Address comments * Force to lower case * Caps Lock vs Shift behavior * Scroll on long keyboard input * Adjust text for tab keypress * Adjust tab size to 8
* Add slider modal * Add action update slider position * Add appId param to updateSliderPosition action * Send response based on slider close reason * Implement CancelInteraction for Slider * Implement slider component UI * Apply theme to slider component * Remove unnecessary logs * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Address review comments * Add padding between appName and sliderHeader * Implement static slider footer * Overhaul react slider component UI * Address review comments * Add recommended width for sliderHeader and sliderFooter textfield capabilities * Add enclosing block for Slider RPC case * Fix cursor switching issue * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Implement RPC UI.ClosePopUp * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Add block for UI.ClosePopUp case * Return ABORTED response for unimplemented VR.PerformInteraction RPC * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Add cases for Slider and ScrollableMessage interactions * Search through apps for interaction rather than only using activeApp Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Remove rail background div and change border-radius * Set same width for - and + buttons * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* TTS Stop Speaking * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Reject speak request if one in progress * OnResetTimeout and long speech fix * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Dont allow empty strings * Update src/js/Controllers/TTSController.js Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Update src/js/Controllers/TTSController.js Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Implement RPC UI.ClosePopUp * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Add block for UI.ClosePopUp case * Return ABORTED response for unimplemented VR.PerformInteraction RPC * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Add cases for Slider and ScrollableMessage interactions * Search through apps for interaction rather than only using activeApp * Perform Audio Pass Thru * Address comments Co-authored-by: Shobhit Adlakha <adlakhashobhit@gmail.com> Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Implement RPC BasicCommunication.DecryptCertificate * Add certificate passphrase as a command line argument to the start_server script * Apply suggestions from code review Co-authored-by: Collin <iCollin@users.noreply.github.com> * Add changes to decrypt the pkcs12 certificate bundle Co-authored-by: Collin <iCollin@users.noreply.github.com>
* add consent prompts, toast notifications, get user friendly message, app permissions view, include bootstrap, handle OnAppPermissionChanged, refactor tts controller so HMI can easily queue tts * improve applist header icons * GUFM response.result.messages param may be omitted * replace consumer friendly message variables with proper values * minor styling improvements * remove menu icon from app permissions list * address review comments: data consent before permissions, chain views, activate app once * remove activate app when permissions consent * consumer friendly message tts api parameter is called ttsString * rename AppPermissionList to PermissionAppList to make it more clear that is the list of apps * get revoked app name before waiting for GUFM response (while its still in app list) * reply to TTS Speak correctly even when internal TTS is being used * fixup! rename AppPermissionList to PermissionAppList to make it more clear that is the list of apps fix links to renamed page * handle ActivateApp request parameter level * address review comment: fix warning * address review comment: add comment explaining filePlaylist type REPLY * nullcheck editing permissions app * fix AppPermissionsRevoked tts * handle app unregister while editing permissions * fix AppPermissions prop name typo
This reverts commit eb363bd.
* reduce scrollableMessageBody row count according to HMI API TextField.rows.maxvalue * remove textFields from imageFields
* Add github ci for build check * Add steps for backend server start
* Added box for reseting timeout (Reset period input); added Reset timeout button on Alert pop-up with connection to value from Reset period input * Created function for Alert resetting with timer and using set value of reset period * Added function for checkboxes * Merged changes * Added impl onreset timeout for UI.Alert only * Fix int type * Minor Updates * Minor changes * Add possibility to reset Speak * Fix AAW-921 HMI sends BC.OnResetTimeout for TTS.Speak request in case Alert has been requested without TTS part * Fix AAW-923 HMI sends TTS.Speak requets after UI.Alert without timeout resetting * Fix AAW-925 It's able to send BC.OnResetTimeout for request that has already processed * Fix AAW-926 HMI sends default reset period instead of set value after app reconnect * Added out of bound event emitter * SDL-0189 Restructuring onResetTimeout Updated reducers.js * SDL-0189 Restructuring OnResetTimeout Updated TTSController * Extended UIController Added resetPerformInteractionTimeout method * Extended UIController Added implementation for resetPerformInteractionTimeout method * Added reset timeout button and counter for PerformInteraction rpc * Connected reset timeout component to reset function for performInteraction * Changed position for reset timeout box for performIntetaction; fixed bugs with timers * Fixed variables in HScrollMenu and UIController * Fixed for PI timeout started value; added out of bound function; changed label for PI counter * Fixed value of starting timeout duration value for Alert rpc * Alert and Speak fixex * Fixed value of starting timeout duration value for Alert rpc * SDL-0189 Retructuring OnResetTimeout Added new timeout interface usage for slider, scrollablemessage * SDL-0189 Restructuring OnResetTimeout Get reset period value from input for alert, subtlealert, scrollablemessage * Remove unused code * SDL-0189 Answer for review * SDL-0189 Updated TTSController * get rid of reactjs-eventemitter * Remove unused code * SDL-0189-Fixed-background-color-of-reset-button-according-to-theme * Fixed wrong imports * Resolve merge conflict * Fix reducer return value * Fix/SDL 0192 deleted unused action and state variable * Fixed with removing of unused variable * Fixed params of onResetTimeout for speak case * Fixed: removed speak from UI state * Fix SubtleAlert (#19) * Fix SubtleAlert * SDL-0189 Fixed response sending for TTS.Speak request * Fixed alert for softButtons * Removed unused variable * Changed state of resetTimeout from state per app to single state * Removed reset timeout functionality for PerformInteraction * Fix PerformInteraction RPC with interaction Layout = KEAYBOARD (#24) * SDL-0189 Implemented check if Speak is ended after Aler timeout * SDL-0189 Fixed speechsynthesis Fixed speechsyntesis, which sometimes not ended. Also removed unused params from callbacks. * SDL-0189 Removed decremented timeout * SDL-0189 Removed redundant css * Transferred resetTimeout to state called system * SDL-0189 Answer for review comment related to TTS.Speak * SDL-0189 Revert file changes in Alert.js * SDL-0189 Removed redundant speakEnded() call * SDL-0189 Removed redundant lines after rebase * Fixed issues according last comments * SDL-0189 Removed redundant parseInt * Review answers * Fixed issues according last comments * Fixed issues according last comments * Fixed issues according last comments * Resolved issue with OUT_OF_BOUND_RESET_PERIOD * Fixed issue * Fixed gaps in Alert file * Fixed alert for softButtons * Removed unused variable * Changed state of resetTimeout from state per app to single state * Removed reset timeout functionality for PerformInteraction * Fix PerformInteraction RPC with interaction Layout = KEAYBOARD (#24) * SDL-0189 Implemented check if Speak is ended after Aler timeout * SDL-0189 Fixed speechsynthesis Fixed speechsyntesis, which sometimes not ended. Also removed unused params from callbacks. * SDL-0189 Removed decremented timeout * SDL-0189 Removed redundant css * Transferred resetTimeout to state called system * SDL-0189 Answer for review comment related to TTS.Speak * SDL-0189 Revert file changes in Alert.js * SDL-0189 Removed redundant speakEnded() call * SDL-0189 Removed redundant lines after rebase * SDL-0189 Removed redundant parseInt * Fixed issues according last comments * SDL-0189 Applied necessary changes for TTSController.js * SDL-0189 Update src/index.js reset timeout input field type Co-authored-by: Collin <iCollin@users.noreply.github.com> * Fixed - minor changes * Removed unused expression * Removed inappropriate structures and values * Added~const DEFAULT_TIMEOUT_VALUE in UIController for common use * Added~const DEFAULT_TIMEOUT_VALUE in UIController for common use Co-authored-by: LiliiaShlikhtLuxoft <lshlikht@luxoft.com> Co-authored-by: valerii <valera.malkof@gmail.com> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com> Co-authored-by: Valerii Malkov <VMalkov@luxoft.com> Co-authored-by: YuriiYefimenko <yurii.yefimenko@dxc.com> Co-authored-by: Yurii Yefimenko (GitHub) <86713844+YuriiYefimenko@users.noreply.github.com> Co-authored-by: LiliiaShlikhtLuxoft <85491862+LiliiaShlikhtLuxoft@users.noreply.github.com> Co-authored-by: Collin <iCollin@users.noreply.github.com>
* SDL-0192 OnButtonSubscription notification removed; SubscribeButton RPC added * SDL-0192 Added UnsubscribeButton RPC * Extended capability * Restructure buttonCapabilities Co-authored-by: LiliiaShlikhtLuxoft <lshlikht@luxoft.com> Co-authored-by: YuriiYefimenko <yurii.yefimenko@dxc.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* remove MEDIA template from non-media app capabilities * fix writing capabilities objects, check for disallowed SetDisplayLayout, check isMediaApplication instead of appType
* Hide overflow for alert text * Fix horizontal overflow
* restrict main fields of non media template * break/wrap mainfield3/4 with no spaces
* cancel interaction only applies to interactions from same app * Update src/js/Controllers/UIController.js Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Apply suggestions from code review Account for interactions being cancelled while the interaction's owner is not the active app. Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * update system context RPCs sent via ClosePopUp * prevent sending context MENU to background app in OnClose methods * update context changes in onDefaultAction and onSliderClose * update context changes for onStealFocus * in case of Slider/ScrollableMessage dont send HMI_OBSCURED to app which started the interaction * Update src/js/Controllers/UIController.js Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Add TILES_WITH_GRAPHIC and GRAPHIC_WITH_TILES templates
* Add Status Update Icon * Review comments * Refactor + animations * Remove timeout * Margin right spacing * Refactor app store icon * Settings Page * Remove app header icon changes * Fix Settings Title * Line break * Refactor AppName * Update icons * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Update cart icon * Update if/else priority for name props.value * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Add svg-stroke class to icon * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Add default ok button if no alertbuttons are present * Move default ok button to Buttons.js
* add new templates GRAPHIC_WITH_TEXT_AND_SOFTBUTTONS and TEXT_AND_SOFTBUTTONS_WITH_GRAPHIC * change mainfields in new templates to only allow one line of text * move image above text on soft button * limit the number of softbuttons on the new templates
* Fix keyboard mask checkbox css * Align items: flex end
Co-authored-by: LiliiaShlikhtLuxoft <lshlikht@luxoft.com>
* Check timer bounds before setting position when paused * Address review comments * Add progressbar changes and address comments * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Change overflow value to auto * Fix default click handler for install app tile * Address comment * Apply suggestions from code review Co-authored-by: Collin <iCollin@users.noreply.github.com> Co-authored-by: Collin <iCollin@users.noreply.github.com>
* fix tts in firefox * update ubuntu versions required for sdl core * bold note that Chromium is only supported browser
iCollin
approved these changes
Oct 8, 2021
response in case PTU contains decrypted certificate
jacobkeeler
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HMI Changes released with SDL Core Release 8.0.0
Features
[SDL 0189] Restructuring OnResetTimeout
[SDL 0192] Button Subscription response from HMI
Feature Additions For Missing UI Components
Add the ability to highlight soft buttons
Update minimum supported version to ubuntu 18
To implement remaining keyboard features
Implement a Progress Indicator
Bug Fixes
Only send OnReceivedPolicyUpdate for request type PROPRIETARY
PerformInteraction tertiaryText not showing
Add support for showing choice set items as a tiled list of icons
Alert soft buttons with images are not formatted correctly
Alert soft button image alignment issues
Incorrect interface name used for OnResetTimeout RPC notifications
Duplicate OnUpdateSubMenu Send When HMI Receives AddSubmenu
Sending an OnAppCapabilityUpdated RPC with an empty VideoStreamingCapability object causes a crash
GitHub Actions CI
Alert with soft buttons should respond ABORTED on timeout
Media template bugs
HMI responds with SUCCESS result code to the VR.PerformInteraction request in case choice was not performed in BOTH interaction mode
The text in mainField1 overflows in the Non-Media template if the text is too long
Fix text formatting on alerts
CancelInteraction only applies to interactions from same app
HMI disconnects from the backend server after a failed HMI PTU
Add Status Update Icon
Add a default "OK" button to alerts without soft buttons
SetGlobalProperties(menuLayout) does not affect existing SubMenus
UI.SetMediaClockTimer(PAUSE) setting position time over bounds
Adjust TTS Controller to support Firefox
Missing imageField capabilities