Add padding to Alert softbuttons and adjust size #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobkeeler
changed the title
ShobhitAd
requested changes
May 18, 2021
src/css/components/_alert.scss
Outdated
| @@ -102,6 +102,10 @@ | |||
| padding: 15px; | |||
| } | |||
|
|
|||
| .alert-buttons .soft-button-image-static { | |||
| padding: 5px; | |||
There was a problem hiding this comment.
I think the padding should also be added for SubtleAlert Softbuttons (.v-subtleAlert-button-1 .soft-button-image and .v-subtleAlert-button-2 .soft-button-image)
There was a problem hiding this comment.
Addressed in 6f869b9
src/css/components/_alert.scss
Outdated
| @@ -102,6 +102,10 @@ | |||
| padding: 15px; | |||
| } | |||
|
|
|||
| .alert-buttons .soft-button-image-static { | |||
There was a problem hiding this comment.
Suggested change
| .alert-buttons .soft-button-image-static { | |
| .alert-buttons .soft-button-image, .soft-button-image-static { |
Issue also applies to softbuttons with dynamic images
There was a problem hiding this comment.
Addressed in 6f869b9
src/css/components/_alert.scss
Outdated
| @@ -158,4 +162,9 @@ | |||
| @include display(flex); | |||
| @include align-items(center); | |||
| @include justify-content(center); | |||
| } | |||
|
|
|||
| .alert-button-4 .soft-button-image-static { | |||
There was a problem hiding this comment.
Suggested change
| .alert-button-4 .soft-button-image-static { | |
| .alert-button-4 .soft-button-image, .soft-button-image-static { |
Issue also applies to softbuttons with dynamic images
There was a problem hiding this comment.
Addressed in 6f869b9
ShobhitAd
approved these changes
May 20, 2021
This was referenced May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369, #343
Testing Plan
Core Tests
Test alerts with 1, 2, 3, or 4 softbuttons with various combinations of text and images
Core version / branch / commit hash / module tested against: 7.1.0
Proxy+Test App name / version / branch / commit hash / module tested against: RPC Builder JS
Summary
Adds padding to Alert softbutton images, also adjusts size of images when appropriate
Changelog
Bug Fixes
CLA