Feature/Alert Default ok button #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCollin
requested changes
Aug 24, 2021
src/js/AlertButtons.js
Outdated
| @@ -29,7 +29,19 @@ export default class AlertButtons extends React.Component { | |||
| var softButtons = this.props.alertButtons | |||
| var items; | |||
| if(!softButtons){ | |||
| return (null) | |||
| let okButton = { | |||
There was a problem hiding this comment.
We should add msgID property so that a response will be sent by uiController.onDefaultAction:
There was a problem hiding this comment.
It's difficult to directly get the msgId in AlertButtons.js so I've moved the default ok button changes to Buttons.js in b333f1e
iCollin
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297
Testing Plan
Core Tests
Send Alert RPC without softbuttons
Core branch tested against: develop
Proxy+Test App name tested against: RPC Builder
CLA