TTS Stop Speaking #405
Merged
TTS Stop Speaking #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobkeeler
requested changes
Jun 22, 2021
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
jacobkeeler
reviewed
Jun 24, 2021
jacobkeeler
requested changes
Jun 24, 2021
jacobkeeler
reviewed
Jun 24, 2021
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
jacobkeeler
requested changes
Jun 24, 2021
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
jacobkeeler
approved these changes
Jun 24, 2021
LiliiaShlikhtLuxoft
pushed a commit
to LuxoftSDL/generic_hmi
that referenced
this pull request
Jul 19, 2021
* TTS Stop Speaking * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Reject speak request if one in progress * OnResetTimeout and long speech fix * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Dont allow empty strings * Update src/js/Controllers/TTSController.js Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> * Update src/js/Controllers/TTSController.js Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #401 Partially
Testing Plan
Core Tests
Send alert with tts file that is longer than the alert timeout (putfile any music mp3). Stop speaking is sent by SDL Core if the alert hits its duration without a user interaction.
Core version / branch / commit hash / module tested against: [INSERT]
Proxy+Test App name / version / branch / commit hash / module tested against: [INSERT]
Summary
CLA