Consent & GetUserFriendlyMessage #406
Conversation
…app permissions view, include bootstrap, handle OnAppPermissionChanged, refactor tts controller so HMI can easily queue tts
| }); | ||
| } else { | ||
| if (this.statusMessages[status].tts) { ttsController.queueTTS(this.statusMessages[status].tts); } | ||
| toast((_toast) => (<PermissionsPopup _toast={_toast} header={this.statusMessages[status].line1}/>), { duration: 2000 }); |
There was a problem hiding this comment.
| toast((_toast) => (<PermissionsPopup _toast={_toast} header={this.statusMessages[status].line1}/>), { duration: 2000 }); | |
| toast((_toast) => (<PermissionsPopup _toast={_toast} header={this.statusMessages[status].line1}/>), { duration: 5000 }); |
2000 seemed a little too fast
There was a problem hiding this comment.
They're so quick to digest, and often all three come within 2 seconds. Having all three popups covering half of my screen for 3seconds would annoy me, even knowing this won't happen often at all.
I am not opposed to extending the time a bit, but I think 5s is long, that is what I originally used.
|
Hide menu icon when viewing permissions list. Clicking menu causes error |
|
I think the data consent prompt for SDL should come before acknowledging the app permissions being requested |
|
Disabling an allowed permission and then pressing save does not save the state. No messages are sent to Core for disallowing the permission |
|
Activating an app for the first time is requiring the user to activate the app twice. The data-consent + app permissions view should be chained together with one click to activate an app. |
|
Experiencing an issue with external policies connected with the sdl server. After activating an app for the first time i am presented with the consent prompt. I agree and then the PTU takes place. After the PTU is successful I am given the list of permissions to accept or deny. After I hit save the view takes me back to the app list instead of the app in full. I am not able to activate the app at this point, the app list is stuck |
…hat is the list of apps
…clear that is the list of apps fix links to renamed page
I was able to reproduce this scenario but in my tests, after the PTU takes place the HMI receives a ChangeRegistration and an ActivateApp with In the current state, after saving permissions, I could not find any issues with activating the app. |
src/js/Controllers/TTSController.js
Outdated
| window.speechSynthesis.pause(); | ||
| window.speechSynthesis.cancel(); | ||
| var file = null; | ||
| while (file = this.filePlaylist.shift()) { |
There was a problem hiding this comment.
This is causing a warning when building the app
There was a problem hiding this comment.
fixed warning in d15c407
| for (var i=0; i<ttsChunks.length; i++) { | ||
| this.filePlaylist.push(ttsChunks[i]) | ||
| } | ||
| this.speakID = rpc.id; | ||
| this.listener.send(RpcFactory.TTSStartedNotification()); | ||
| this.filePlaylist.push({ type: 'REPLY', id: rpc.id }); |
There was a problem hiding this comment.
Please add code comments for this reply type since a developer might assume this is a type associated with the hmi api
There was a problem hiding this comment.
good point, I added a comment in two places in 4c4152a
* add consent prompts, toast notifications, get user friendly message, app permissions view, include bootstrap, handle OnAppPermissionChanged, refactor tts controller so HMI can easily queue tts * improve applist header icons * GUFM response.result.messages param may be omitted * replace consumer friendly message variables with proper values * minor styling improvements * remove menu icon from app permissions list * address review comments: data consent before permissions, chain views, activate app once * remove activate app when permissions consent * consumer friendly message tts api parameter is called ttsString * rename AppPermissionList to PermissionAppList to make it more clear that is the list of apps * get revoked app name before waiting for GUFM response (while its still in app list) * reply to TTS Speak correctly even when internal TTS is being used * fixup! rename AppPermissionList to PermissionAppList to make it more clear that is the list of apps fix links to renamed page * handle ActivateApp request parameter level * address review comment: fix warning * address review comment: add comment explaining filePlaylist type REPLY * nullcheck editing permissions app * fix AppPermissionsRevoked tts * handle app unregister while editing permissions * fix AppPermissions prop name typo
Summary
This PR is ready for review.
This PR adds the following functionality:
This PR also refactors the TTS controller a bit so that the HMI can easily queue TTS and to prevent TTS conflicts.
To Do
Future Considerations
CLA