Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard mask checkbox css #436

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

Jack-Byrne
Copy link
Collaborator

@Jack-Byrne Jack-Byrne commented Sep 2, 2021

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Core Tests

  • Set global properties with keyboard user input mask enabled
  • Verify placement of checkbox

Core version / branch / commit hash / module tested against: 8.0
Proxy+Test App name / version / branch / commit hash / module tested against: rpcb-js

Summary

Fixes CSS of the user mask checkbox. It was previously wrapped and non-visible in the parent div.

CLA

Copy link
Collaborator

@iCollin iCollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you like the checkbox on the top of the text input, the PR is great as is.
on master, the checkbox is vcenter, so I have left suggestions to vcenter it here as well

@Jack-Byrne Jack-Byrne merged commit ac854db into release/0.11.0 Sep 9, 2021
@Jack-Byrne Jack-Byrne deleted the fix/keyboard_mask_input_checkbox branch September 9, 2021 14:56
@theresalech theresalech added the 0.11 Release Issues introduced in 0.11 development label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.11 Release Issues introduced in 0.11 development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants