-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/App store description overflow CSS #441
Fix/App store description overflow CSS #441
Conversation
@@ -63,7 +63,7 @@ | |||
max-height: calc((#{$master-height} - 75px) * 0.6); | |||
|
|||
h4 { | |||
overflow: scroll; | |||
overflow: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With auto I cannot scroll down on an alert with too much text.
For ex when I send this alert I can tell the text continues down past the bottom of the container but I cannot read that text or scroll down to it.
Alert {"alertText1":"Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Donec quam felis, ultricies nec, pellentesque eu, pretium quis, sem. Nulla consequat massa quis enim. Donec pede justo, fringilla vel, aliquet nec, vulputate eget, arcu. In enim justo, rhoncus ut, imperdiet a, venenatis vitae, justo. Nullam dictum felis eu pede mollis pretium. Integer tincidunt. Cras dapibu"}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that this bug is due to my change as part of the Scrollable Message implementation: https://github.com/smartdevicelink/generic_hmi/pull/394/files#diff-086204f81abae904e396dcfbfcfe45acdffa9541673ff56447fe45b3b8063118R10 I made it possible for the Scrollable Message scroll bar to still be visible, not realizing that it will affect other interactions. I suppose this should be modified to affect a smaller scope. |
Unfortunately, I'm not able to overwrite the I did find that removing https://github.com/smartdevicelink/generic_hmi/pull/441/files#diff-086204f81abae904e396dcfbfcfe45acdffa9541673ff56447fe45b3b8063118L10 did not affect the visibility of scrollbars for other interactions (Alert, AppStore, ScrollableMessage, etc.) so I removed that section and changed the overflow value for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good otherwise!
Co-authored-by: Collin <iCollin@users.noreply.github.com>
Fixes #440
Testing Plan
Core Tests
Install and uninstall the "Hello Webengine" app
Core version tested against: release/8.0.0 (smartdevicelink/sdl_core@5da5770)
Summary
.alert-top h4
overflow value to "auto". The previous value ("scroll") would always display scrollbars, whether or not any content is actually clipped.Bug Fixes
Currently clicking an installed(grayed out) app tile in the app store results in a console error
This PR fixes the default click handler for the
menuItem.greyOut
caseCLA