Feature/sdl 0192 button subscription response from hmi #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jordynmackool this PR is ready for review and is approved by Ford. |
jacobkeeler
requested changes
Jul 28, 2021
|
@LitvinenkoIra, just checking in to make sure you've received Jacob's review. Please let us know if you have any questions or concerns with addressing his feedback. If you could also provide us with an anticipated date for when this PR will be ready for Livio's re-review, we'd appreciate it! Thank you! |
|
@theresalech Thank you for the reminder! We are working on the comments right now and will provide updates by early next week. |
Review answers
… into fix/SDL-0192-fixes-for-ButtonSubscription-review
…bscription-review Fixes according comments from ButtonSubscription review
Resolved error with GENERIC ERROR const
…ties Fix buttonCapabilities
jacobkeeler
requested changes
Aug 9, 2021
|
Also fix conflicts |
Restructure buttonCapabilities
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
jacobkeeler
requested changes
Aug 10, 2021
Fix/sdl 0192 sync develop
jacobkeeler
requested changes
Aug 11, 2021
…-for-new-comments Removed unused data
jacobkeeler
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #107
Testing Plan
Core Tests
Core version / branch / commit hash / module tested against: https://github.com/LuxoftSDL/sdl_core/tree/feature/sdl_0192_button_subscription_response_from_hmi
Proxy+Test App name / version / branch / commit hash / module tested against: SyncProxyTester
Summary
CLA