Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new templates Graphic with Text and Soft Buttons #433

Merged
merged 5 commits into from
Aug 30, 2021

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented Aug 27, 2021

Summary

Adds two new templates: GRAPHIC_WITH_TEXT_AND_SOFTBUTTONS and the mirrored TEXT_AND_SOFTBUTTONS_WITH_GRAPHIC

Testing Plan

  • I have verified that I have not introduced new warnings in this PR
  • I have tested this PR against Core and verified behavior

To test, send a Show with one of the new templates, a graphic, some main field text, and 1-3 soft buttons

CLA

@Jack-Byrne
Copy link
Collaborator

Sizing issues when using 4 softbuttons. I would also suggest for softbuttons with images have the image on top of the text, similar to other tiles like buttons.

Screen Shot 2021-08-30 at 2 06 42 PM

@iCollin
Copy link
Collaborator Author

iCollin commented Aug 30, 2021

Sizing issues when using 4 softbuttons

Ah, the template only supports 3, so in bb5936c I made the HMI actually enforce this limit.

suggest for softbuttons with images have the image on top

Added in 1bbbecd

@iCollin iCollin merged commit 523d35a into develop Aug 30, 2021
@iCollin iCollin deleted the feature/new_template_gwtasbs branch August 30, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants