Call for reviewers group and new co-reviewing workflow

[jywarren]

Fixes #173 (😆 🎉)

One year ago, I posted #173 - Building out a contributor community for Image Sequencer, and talked a lot with @tech4GT about how to do this. As you can now see, with your help, we now have a lively community around this library!

Community growth

Check out some of these pages to see how many people have helped build Image Sequencer, since @ccpandhare and I started the project ~3 years ago:

• Community Toolbox: https://code.publiclab.org/#r=image-sequencer
• GitHub Pulse: https://github.com/publiclab/image-sequencer/pulse/monthly
• Contributors graphs: https://github.com/publiclab/image-sequencer/graphs/contributors

43 people have now committed code to the project, and even more have participated! 😄 🎉

What's next: co-review workflow

To build on this community strength 🤝, we'd like to ask for people to sign up as reviewers, to help get pull requests ready for merging. In the new workflow, we'd like each PR to have:

1. ✅ 2 reviews by people from the @publiclab/is-reviewers group
2. ✅ a ready-to-merge label, once ready for final review by someone with merge permissions (currently @tech4GT and I, although we are interested in expanding this group soon)
3. ✅ tests if possible (not mandatory but preferred)

This doesn't mean that we should stop helping each other solve problems even if we're not in the reviewers group -- i've seen a lot of great welcoming and cooperation! But at least we'll be able to get things ready and merged faster. 👍 🙌

Reviewers team

So, this new @publiclab/is-reviewers team -- we'd like to ask folks to join it if you're interested! Many of you already play this role -- THANK YOU! 🎉 We'd like folks to consider, as a prerequisite to joining:

1. ✅ having 2 PRs merged
2. ✅ having helped someone else troubleshoot a PR or issue
3. ✅ having made a first-timers-only issue and welcomed in a new person to make their own first contribution (this is how our community grows!)

If you've completed these, please ask here and we'll be sure to add you the new reviewers group. You'll get notifications when people request a review from you, or mention @publiclab/is-reviewers.

Managing too many emails!

Just a note - your inbox can become quite a mess as the community grows! Consider turning off notifications for /every event/ and just listening to if you're mentioned! 📬

THANK YOU for making this corner of the Public Lab coding community a warm, welcoming, and wonderful place!!! ⚡️ 🙌 👍 🎉 🎉 🎉

@aashna27 @harshkhandeparkar @Divy123 @sashadev-sky @MargaretAN9 @ROODAY @VibhorCodecianGupta @Mridul97 @KusioDev @okonek @JonathanXu1 @Rishabh570 @bhavayAnand9 @oorjitchowdhary @roshniRam @publiclab/reviewers @publiclab/image-sequencer-guides @Ankit-Singla @rexagod

[Divy123]

@jywarren I have fulfilled all the conditions as mentioned to join this wonderful team .
Please consider me adding to the list of reviewers.

[vibhorgupta-gh]

@jywarren Checked the prerequisite checkboxes here as well. Having a lot of fun with Image Sequencer, would absolutely love to be a part of the co-reviewing group!

[aashna27]

yes me too 🙌 Happy to have this opportunity 😄 😃 Looking forward to being involved more !! Thanks @jywarren @tech4GT . 🎉

[Mridul97]

@jywarren I would love to be in this team, have checked all the conditions. Thanks! 😄

[jywarren]

Thank you all! I've added you four. 🎉 Awesome!

[jywarren]

I'd like to also note that reviewers, like any community member, have a responsibility to support and uphold our code of conduct! This is part of what makes our community a respectful and fulfilling place. Please give it a careful read! http://publiclab.org/conduct 🎉

[harshkhandeparkar]

I would have liked to join this too but I will be super busy for the next 2 years and won't be able to do anything. Can I still join and be redundant for 2 years?

[jywarren]

I think that's fine, @harshkhandeparkar! I'll add you too --have you also completed the prerequisites? Thank you!

[rexagod]

@jywarren I'd like to be in this team, too. Can I join?

[tech4GT]

It's really nice to see our community grow here, our efforts definitely paid off! 🎉❤️

[harshkhandeparkar]

I would have liked to join this too but I will be super busy for the next 2 years and won't be able to do anything. Can I still join and be redundant for 2 years?

Yes I have completed the prerequisites. Thanks!

[jywarren]

Adding @harshkhandeparkar. I believe @rexagod has completed these although for other Public Lab projects in some cases, but they are similarly structured JS libs. So I think it translates pretty well! Adding you both. Thanks!

If folks can explicitly click "Approve" on PRs that would be great.

If you need reviews, please use the needs-review label - that way others can scan through in the PR list. If you have 2 approved reviews, please use the ready-to-merge label. This'll help us be more efficient!

[milaaraujo]

I can be a reviewer, @jywarren! :)

[jywarren]

Thanks, @milaaraujo ! I'll add you to the matching plots2-reviewers group. We'll probably do a more formal call there soon.

[harshithpabbati]

Can I be the part of the reviewers team.
#782
publiclab/community-toolbox#140
These are my merged pr's

[grvsachdeva]

You need to have one more merged PR, review one PR to completion and open an FTO in this repo.

[harshithpabbati]

Hello
I am done with 2 merges
Created few issues
Helped one to solve the issue
Now can I be the part of reviewers team:)

[harshithpabbati]

@gauravano can you check it out now!!

[grvsachdeva]

Please paste the links. Thanks!

[harshithpabbati]

@gauravano
My pr's
#776
#782
Issues which I made:
#801
#800
#799
#798
#795
#810

[harshkhandeparkar]

Harshith, are you well acquainted with the codebase? Will you be able to help other contributors if needed?

[harshithpabbati]

@harshkhandeparkar yeah i will help other contributors.

[grvsachdeva]

Added you to the @publiclab/is-reviewers @harshithpabbati 🎉 Thank you!

/cc @jywarren @tech4GT

[subhahu123]

@jywarren @gauravano can i be a reviewer ? ( A member of publiclab/is-reviewers)

[harshkhandeparkar]

@subhahu123 I have deleted your comments in the other pr.

[grvsachdeva]

Hi @subahu123, I can't see your issues and PRs from https://github.com/publiclab/image-sequencer/issues/. Could you please list them below? Thanks!

[harshithpabbati]

@jywarren I want to join into the maintainers team. How can I do that ??? Are there any prerequisites to complete???

[jywarren]

Hi Harshith - i'm trying to go through all the SoC and Outreachy proposals now, so i'm sorry to ask but could you copy in my comment from your PR where I mentioned some next steps to formalize the process a bit? Thank you so much and I'm so grateful for your interest in helping maintain the project!!!

…

On Mon, Apr 1, 2019 at 2:49 PM Harshith pabbati ***@***.***> wrote: @jywarren <https://github.com/jywarren> I want to join into the maintainers team. How can I do that ??? Are there any prerequisites to complete??? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#656 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJyWtES42eCVpFUfQJKlUO8nZrtT_ks5vclSygaJpZM4Z77JG> .

[rishabhshuklax]

Hi @jywarren !
Can I also join the reviewer team?

[jywarren]

Hi! Thank you, can you link to your PRs and issues as above? Thanks, and awesome!!

[rishabhshuklax]

@jywarren
My PRs
#1432
#1459
#1482
#1513
#1463
#1309

Issues which I opened
#1488
#1452
#1430
#1460
#1464
#1431

Thanks!

[jywarren]

Fantastic, thank you! Adding you now.

[ataata107]

Hi @jywarren I would like to be part of this team
Kindly find my issues and PR's as follows
Issues
#1370
#1383
#1402
#1411
#1429
#1457
#1498

PR's
#1379
#1386
#1395
#1403
#1412
#1428
#1442
#1450
#1455
#1456
#1458
#1489
#1491
#1533

[jywarren]

Great, adding you! Thank you!