Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a footer to the main page #776

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Added a footer to the main page #776

merged 2 commits into from
Feb 20, 2019

Conversation

harshithpabbati
Copy link

@harshithpabbati harshithpabbati commented Feb 15, 2019 •
edited by harshkhandeparkar
Loading

Fixes #335

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers and @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@harshithpabbati
Copy link
Author

@publiclab/is-reviewers

1 similar comment
@harshkhandeparkar
Copy link
Member

@publiclab/is-reviewers

@Divy123
Copy link
Member

Divy123 commented Feb 15, 2019

Can you please provide a screenshot for this?
Thanks

@harshithpabbati
Copy link
Author

screenshot from 2019-02-15 12-43-47
@Divy123

@harshithpabbati harshithpabbati mentioned this pull request Feb 16, 2019
Closed
4 tasks
@harshithpabbati
Copy link
Author

@jywarren please review it.

Divy123
Divy123 requested changes Feb 16, 2019
View reviewed changes
examples/index.html
@@ -189,6 +189,26 @@ <h2 style="margin-top:20px">Save</h2>

<footer>
<hr style="margin:20px;"><center><a class="color:grey;" id="clear-cache">Clear offline cache</a></center>
<div class="row">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that the footer section should be at the bottom of the page, I mean there should be no space below it as well.
Can you please do this after a review by @jywarren ?
Thanks

Divy123
Divy123 requested changes Feb 16, 2019
View reviewed changes
examples/index.html Show resolved Hide resolved
@harshithpabbati
Copy link
Author

screen
@Divy123 is this ok??

@Divy123
Copy link
Member

Divy123 commented Feb 16, 2019 •
edited
Loading

Ya this one is good.

I suggest that the footer section should be at the bottom of the page, I mean there should be no space below it as well.
Can you please do this after a review by @jywarren ?
Thanks

Lets wait for Warren's review.

@harshithpabbati
Copy link
Author

I will send the pull request after he his review

@harshithpabbati
Copy link
Author

@jywarren review it :)

@harshithpabbati
Copy link
Author

@publiclab/is-reviewers

@harshithpabbati
Copy link
Author

@jywarren please review it.

@harshkhandeparkar
Copy link
Member

Harshithpabbati you will have to wait for another 24hrs before jywarren reviews this as it will be a sunday beginning for his timezone. Thanks!

@harshithpabbati
Copy link
Author

@jywarren please review it

@harshithpabbati
Copy link
Author

@publiclab/is-reviewers

@jywarren
Copy link
Member

Thanks for your patience and sorry for the delay, this looks great!

@jywarren jywarren merged commit 194e6fc into publiclab:main Feb 20, 2019
@harshithpabbati
Copy link
Author

Thanks @jywarren

@harshithpabbati harshithpabbati mentioned this pull request Feb 21, 2019
Open
@harshithpabbati harshithpabbati mentioned this pull request Mar 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Divy123 Divy123 Divy123 requested changes

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshithpabbati @harshkhandeparkar @Divy123 @jywarren