Added the footer to the main page #775
Conversation
|
@publiclab/reviewers
|
|
Hi, do you think you could share a screenshot? Thanks! |
|
|
|
@harshithpabbati you don't need to tag publiclab/reviewers, @publiclab/is-reviewers is enough. The reviewers group includes all the reviewers and also the reviewers of other projects like plots. Thanks! |
|
Also you can remove square brackets around the issue number so that becomes a proper link(like i just did) |
|
Fo you think centered text for the columns will look better? |
| <a class="btn btn-primary" href="https://publiclab.org/questions">Ask a question »</a> | ||
| </p> | ||
| </div> | ||
| <div class="col-md-6"> |
There was a problem hiding this comment.
A class of col-sm-12 along with col-md-6 will be better
There was a problem hiding this comment.
Sure i will make the changes,😁
There was a problem hiding this comment.
Shall i change the link to github issues??
| Post a link to this and ask for help from other community members on <a href="https://publiclab.org/">PublicLab.org</a> | ||
| </p> | ||
| <p> | ||
| <a class="btn btn-primary" href="https://publiclab.org/questions">Ask a question »</a> |
There was a problem hiding this comment.
I don't think linking to publiclab.org is good. Maybe link to GitHub issues? Or swap the ask a question section for something else?
There was a problem hiding this comment.
What is your idea about this? Is github issues good? Or should it link to something else?
|
You can put an 'x' inside the checkboxes in the pr body(without leaving any spaces) or you can directly change them from the browser as they are interactive. Thanks. |
|
@jywarren nodejs is throwing an error in the tests. Maybe an npm audit is required? This is happening probably because of depandabot version bumps. |
|
|
|
What I meant was that people can ask a question by opening an issue |
|
Oops did this close by mistake?
I think the public lab link is ok for end users, because not everyone knows
how to open a GitHub issue.
…On Fri, Feb 15, 2019, 6:49 AM Harshith pabbati ***@***.*** wrote:
Closed #775 <#775>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#775 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ96LXT2DDIwonFywGMdgHE2TnP7kks5vNp6mgaJpZM4a8PWD>
.
|
|
I sent a new pr with link of the github issues. |
Fixes #335
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test@publiclab/reviewersand@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!