Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ranged input for overlay module. #1459

Merged
merged 13 commits into from
Jan 16, 2020
Merged

Add ranged input for overlay module. #1459

merged 13 commits into from
Jan 16, 2020

Conversation

rishabhshuklax
Copy link
Member

@rishabhshuklax rishabhshuklax commented Jan 11, 2020 •
edited
Loading

Fixes #1430

overlay

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Jan 11, 2020 •
edited
Loading

Codecov Report

Merging #1459 into main will increase coverage by 0.24%.
The diff coverage is 92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1459      +/-   ##
==========================================
+ Coverage   65.28%   65.52%   +0.24%     
==========================================
  Files         126      128       +2     
  Lines        2601     2625      +24     
  Branches      419      423       +4     
==========================================
+ Hits         1698     1720      +22     
- Misses        903      905       +2
Impacted Files Coverage Δ
src/Modules.js 100% <ø> (ø) ⬆️
src/modules/Average/Module.js 100% <100%> (ø) ⬆️
src/modules/ConstrainedCrop/index.js 100% <100%> (ø)
src/modules/ConstrainedCrop/Module.js 90.9% <90.9%> (ø)

@rishabhshuklax
Copy link
Member Author

@publiclab/is-reviewers please review this.

@harshkhandeparkar harshkhandeparkar mentioned this pull request Jan 12, 2020
Closed
harshkhandeparkar
harshkhandeparkar approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb!

@jywarren
Copy link
Member

This is great. Do you think a simple module test could help to cover this for the future, and protect it? Thank you so much!

@rishabhshuklax
Copy link
Member Author

@jywarren tests added!

@jywarren jywarren merged commit b8c7df7 into publiclab:main Jan 16, 2020
@jywarren
Copy link
Member

Awesome! Thanks!

@rishabhshuklax rishabhshuklax deleted the overlay-inputs branch January 17, 2020 08:05
@rishabhshuklax rishabhshuklax mentioned this pull request Jan 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

@harshkhandeparkar harshkhandeparkar harshkhandeparkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overlay module not working initially
3 participants
@rishabhshuklax @jywarren @harshkhandeparkar