-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy decoded qr #1491
base: main
Are you sure you want to change the base?
Copy decoded qr #1491
Conversation
@publiclab/is-reviewers |
Codecov Report
@@ Coverage Diff @@
## main #1491 +/- ##
==========================================
+ Coverage 55.11% 64.86% +9.74%
==========================================
Files 117 133 +16
Lines 2344 2769 +425
Branches 360 442 +82
==========================================
+ Hits 1292 1796 +504
+ Misses 1052 973 -79
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have requested some changes. Sorry if my initial issue was unclear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the output field, a span
or p
instead of input
or textarea
so that the whole string is visible on the screen.
@harshkhandeparkar sorry for being late. |
Instead of doing this, we can do it in the Module.js itself like we do in Crop or Overlay, that would be much cleaner! image-sequencer/src/modules/Overlay/Module.js Lines 70 to 75 in 7c63bb5
|
There can be other modules which can have string output. Hence I only did it in defaultHtmlStepUi.js instead of changing module.js for all such cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Fixes #1471 (<=== Replace
0000
with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
![ezgif com-video-to-gif (8)](https://user-images.githubusercontent.com/32903329/72305132-da159d80-3698-11ea-9f12-9c935f12d7fc.gif)
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!