-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crop module #1463
Fix crop module #1463
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1463 +/- ##
=======================================
Coverage 64.88% 64.88%
=======================================
Files 127 127
Lines 2597 2597
Branches 418 418
=======================================
Hits 1685 1685
Misses 912 912 |
@publiclab/is-reviewers please review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, although perhaps we should start to ask for a small test for any changes now, that we're doing really well on this stuff! Thank you !!!!!
This could even use a UI test! |
That would be great to protect your fix, what do you think? |
@jywarren @harshkhandeparkar @blurry-x-face just notice this bug caused due to this PR |
Whoa! What happened just before this? I'll look into this immediately and fix this ASAP, thanks @keshav234156 |
the black box should appear on image to be crop in crop step |
🤔 I think I know why this might have happened, I'm sorry, I will fix this ASAP! |
I tried findng but I am stuck, @keshav234156 do you have any idea what is going on here? |
Fixes #1460
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!