Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop Module Not Producing Expected Output #1460

Closed
rishabhshuklax opened this issue Jan 12, 2020 · 5 comments · Fixed by #1463
Closed

Crop Module Not Producing Expected Output #1460

rishabhshuklax opened this issue Jan 12, 2020 · 5 comments · Fixed by #1463
Labels

Comments

@rishabhshuklax
Copy link
Member

Crop Module is not working corectly and maybe it is related to #1457?

crop

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

rishabhshukla1999

@root00198
Copy link
Member

I would like to work on it.

@rishabhshuklax
Copy link
Member Author

Hi @root00198 I'm already looking into this.

You can help by looking for bugs that might have come because of some recent PRs, Thanks!

@ataata107
Copy link

@blurry-x-face I guess the module is working correctly only the text input field is not showing the correct value of the default which I guess needs to be changed. Currently it is showing 0 for all

@rishabhshuklax
Copy link
Member Author

Yes, I've found the bug and will be making a PR for it very soon!

@rishabhshuklax
Copy link
Member Author

Also @ataata107 , while working on this I found that color picker input was not working as expected, after clicking on it, it was just stuck there and I was unable to do anything, are you facing the same problem too? If so then I'll open a new issue for this and will be happy to work on it!

@rishabhshuklax rishabhshuklax mentioned this issue Jan 12, 2020
5 tasks
@harshkhandeparkar harshkhandeparkar changed the title [BUG] Crop Module Crop Module Jan 12, 2020
@harshkhandeparkar harshkhandeparkar changed the title Crop Module Crop Module Not Producing Expected Output Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants