Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an 'undo' feature #799

Closed
harshithpabbati opened this issue Feb 20, 2019 · 16 comments
Closed

Adding an 'undo' feature #799

harshithpabbati opened this issue Feb 20, 2019 · 16 comments

Comments

@harshithpabbati
Copy link

Making a reset button.Which makes it to reset to the most recent change in the sequence

reset

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@harshithpabbati harshithpabbati changed the title Adding a reset button. Adding a reset feature. Feb 20, 2019
@grvsachdeva
Copy link
Member

@publiclab/is-reviewers what do you think about this idea?

@harshkhandeparkar
Copy link
Member

@harshithpabbati can you please elaborate on this?

@harshithpabbati
Copy link
Author

If we made a change which we don't want in that sequence and want to do it again then we have to delete the step and start doing it again.But by adding this feature we can reset it in the step so that it will be very convenient for everyone to use this.
Thanks.

@harshkhandeparkar
Copy link
Member

Do you mean like an undo?

@harshithpabbati
Copy link
Author

Yeah exactly!!

@harshkhandeparkar
Copy link
Member

IS already has the ability to add/remove steps or insert steps or do whatever you want really. Any value in between the sequence can be tweaked(which is why it has got its name). What kind of undo do you mean specifically?

@harshithpabbati
Copy link
Author

See if i want to make a some saturation of some extent and i made a wrong thing.Then i need to delete the step and start making the step so instead of it if I have the reset button it will be easy to solve it

@harshkhandeparkar
Copy link
Member

Harshith you don't have to delete the step, all you have to do is tweak the values and press the apply button and all the succeeding steps will also change. If you want to change a step, you can delete it and insert a different step there. Is there something else which is not achievable by doing this? Or am I saying something wrong?

@harshithpabbati
Copy link
Author

Yeah I mean the same we need to delete and make the other step instead of it.It will be convenient to have a reset button according to me.Lets have some others review
@publiclab/is-reviewers what do you say about it??

@harshkhandeparkar
Copy link
Member

What I meant to say is that you don't have to delete a step if you want to tweak values. You only have to delete a step if if you want to change the core step like change a crop step to saturation. Instead a good idea would be to add a replaceStep functionality(if it doesn't exist already). What do you say?

@harshithpabbati
Copy link
Author

harshithpabbati commented Mar 3, 2019

Hello
@publiclab/is-reviewers what do you think about it???

@aashna27
Copy link

aashna27 commented Mar 3, 2019

@harshithpabbati I think there is some difference of opinion , why dont you give an example to show , how reset would be more friendly, than changing the values. As far as I understand , I think that a reset would undo the most recent change , so suppose you made a brightness of 120 , and then you make it 150 ,and press reset so it will take you to 120.

So basically what I think is that a reset on a module wont show much effect as the user can easily make it 120 manually but yeah if we consider crop module say for example, wherein there are many inputs, so instead of manually switching to last change a reset would simplify the process!!

@harshithpabbati
Copy link
Author

harshithpabbati commented Mar 3, 2019

@aashna27 I mean for modules like crop when we make a change in it.For example: I want to crop the picture to size x and i cropped it to some size y .Now i have to delete it and start it again for the particular step. So if we have a reset feature then image switches to the recent change(simplifying the process).

@aashna27
Copy link

aashna27 commented Mar 3, 2019

No you wont need to delete it, you can do it on the current one only , ie change the values and changes would be made.

@harshithpabbati
Copy link
Author

Oh ok fine sorry for the issue.

@jywarren jywarren changed the title Adding a reset feature. Adding an 'undo' feature Mar 4, 2019
@jywarren
Copy link
Member

jywarren commented Mar 4, 2019

Hi @harshithpabbati i like the brainstorming here. I think this is something we could think more about and discuss, so thank you for opening it. UI design is hard and we need to think about these things regularly as we work, or we'll miss good ideas. In this case, it looks like people feel that it's not needed, but we might revisit in the future and this kind of discussion is good. So thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants