Fixed Unresponsive Select Step Box

[rohithGoudM]

Fixes #924

Both the select and button elements are stashed in a row.
One with col-md-8 and the other with col-md-4 respectively.

Thanks!

[harshkhandeparkar]

Hey rohith, this includes the changes from your other pr as well.

[harshkhandeparkar]

Cannot differenciate which ones are which.

[rohithGoudM]

I'll create a new folder and clone the whole thing
Give me 5 min

[harshkhandeparkar]

Also please provide a screenshot or gif(preferably gof to show if the changes are responsive on all screen sizes, you can show different sizes of browser by resizing it and taking different screenshots or in a gif). The title of your pr doesn't explain much, can you change that too?

[rohithGoudM]

Ok
So I have to make changes from the original(master) branch, not the one that I have already changed..?
Then I have to repeat the whole process or just checkout from start
I'll figure this out, please be patient

[harshkhandeparkar]

You can remove the other pr changes from this branch and commit. That would be better

[harshkhandeparkar]

Also image-sequencer uses main branch as its default not master.

[rohithGoudM]

I'm having trouble in removing the old commits in the pr
could you please help with that

[harshkhandeparkar]

You can type git rebase -i HEAD~4. This will open a text editor. That editor will have instructions for reverting commits. Or you can just delete the changes and push a new commit.

[rohithGoudM]

here are the screenshots

[harshkhandeparkar]

LGTM! Nice work!

[rohithGoudM]

I tried reverting but it seems that didn't work
I'll delete all the changes one by one

[rohithGoudM]

I have deleted changes related to cursor bug.
But the unresponsive bug has been dealt with

[harshkhandeparkar]

Great!

[rohithGoudM]

How would I know if my changes have been merged with the project..?
Was just curious.

[harshkhandeparkar]

You will get a notification when your pr gets merged.
Your changes will be seen on https://beta.sequencer.publiclab.org in a day or 2

[harshkhandeparkar]

We have two maintainers, @tech4GT and @jywarren. @tech4GT hasn't been very active these days. @jywarren lives in the US so if you live in India (guessed from ur name). You will have to wait and the pr will be merged at night time.

[harshkhandeparkar]

https://sequencer.publiclab.org is updated less frequently (only stable builds are published). Maybe it is updated every 20d or so.

[aashna27]

great work !! can the unnecessary commits be deleted please ?

[jywarren]

It's OK, i can "squash and merge" from GitHub. Thanks, doing that now, thanks for your help!

I'd like to expand the maintainers group but first we should get in a good workflow of getting 2 reviews from reviewers -- #656 -- thank you all for your help!!!

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!