Add test for import image #1513
Conversation
|
@publiclab/is-reviewers please review this |
test/core/modules/import-image.js
Outdated
| const path = require('path'); | ||
|
|
||
| const url = path.join(__dirname, '../images/red.png'); | ||
| console.log(url); |
There was a problem hiding this comment.
Can you remove this console.log and also fix the indentation.
Rest looks good to me
There was a problem hiding this comment.
I forgot to remove the log 😅 , I'll do that ASAP!
test/core/modules/import-image.js
Outdated
| const path = require('path'); | ||
|
|
||
| const url = path.join(__dirname, '../images/red.png'); | ||
| console.log(url); |
There was a problem hiding this comment.
Please remove the log.
There was a problem hiding this comment.
Ohh sorry I forgot, I'll do that ASAP!
Nothing, i just saved it in the test directory to easily import the image, should I remove that and instead import from example? |
Codecov Report
@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
- Coverage 65.47% 65.26% -0.21%
==========================================
Files 127 126 -1
Lines 2598 2594 -4
Branches 418 416 -2
==========================================
- Hits 1701 1693 -8
- Misses 897 901 +4
|
|
@harshkhandeparkar @debck I've made the requested changes, please re-review this! |
|
No. Not an issue.
…On Thu, 16 Jan, 2020, 6:35 PM Rishabh Shukla, ***@***.***> wrote:
Also, what has changed in the red.png file?
Nothing, i just saved it in the test directory to easily import the image,
should I remove that and instead import from example?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#1513?email_source=notifications&email_token=AIJI5H22TNP6HOLA3HUXDL3Q6BLQPA5CNFSM4KHRTTUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJD7RKI#issuecomment-575142057>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJI5HZSUPBTF6JLO2ELQXTQ6BLQPANCNFSM4KHRTTUA>
.
|
|
Awesome!!!! |
|
This is super. Thank you! |
Fixes #1377
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!