Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call For Participation: vectorize all Int builtin functions #12103

Closed
qw4990 opened this issue Sep 10, 2019 · 45 comments
Closed

Call For Participation: vectorize all Int builtin functions #12103

qw4990 opened this issue Sep 10, 2019 · 45 comments
Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@qw4990
Copy link
Contributor

qw4990 commented Sep 10, 2019 •
edited by zz-jason
Loading

This issue is used to trace all vectorized Int builtin functions, which is a part of #12058.

NOTE:

  1. Feel free to join us in the wg-vec-expr working group
  2. Please comment on this issue if you are working on any of the functions.

Note For Performance Challenge Teams: each PR on this issue has 50 score.

  • builtinArithmeticPlusIntSig
  • builtinArithmeticMinusIntSig
  • builtinArithmeticMultiplyIntUnsignedSig
  • builtinArithmeticMultiplyIntSig
  • builtinArithmeticIntDivideIntSig
  • builtinArithmeticIntDivideDecimalSig
  • builtinArithmeticModIntSig
  • builtinCastIntAsIntSig @qw4990 expression: make builtinCastIntAsInt support vectorized evaluation #11826
  • builtinCastRealAsIntSig
  • builtinCastDecimalAsIntSig
  • builtinCastStringAsIntSig
  • builtinCastTimeAsIntSig
  • builtinCastDurationAsIntSig
  • builtinCastJSONAsIntSig
  • builtinCoalesceIntSig
  • builtinGreatestIntSig
  • builtinLeastIntSig
  • builtinIntervalIntSig
  • builtinIntervalRealSig
  • builtinLTIntSig
  • builtinLTRealSig
  • builtinLTDecimalSig
  • builtinLTStringSig
  • builtinLTDurationSig
  • builtinLTTimeSig
  • builtinLTJSONSig
  • builtinLEIntSig
  • builtinLERealSig
  • builtinLEDecimalSig
  • builtinLEStringSig
  • builtinLEDurationSig
  • builtinLETimeSig
  • builtinLEJSONSig
  • builtinGTIntSig
  • builtinGTRealSig
  • builtinGTDecimalSig
  • builtinGTStringSig
  • builtinGTDurationSig
  • builtinGTTimeSig
  • builtinGTJSONSig
  • builtinGEIntSig
  • builtinGERealSig
  • builtinGEDecimalSig
  • builtinGEStringSig
  • builtinGEDurationSig
  • builtinGETimeSig
  • builtinGEJSONSig
  • builtinEQIntSig
  • builtinEQRealSig
  • builtinEQDecimalSig
  • builtinEQStringSig
  • builtinEQDurationSig
  • builtinEQTimeSig
  • builtinEQJSONSig
  • builtinNEIntSig
  • builtinNERealSig
  • builtinNEDecimalSig
  • builtinNEStringSig
  • builtinNEDurationSig
  • builtinNETimeSig
  • builtinNEJSONSig
  • builtinNullEQIntSig
  • builtinNullEQRealSig
  • builtinNullEQDecimalSig
  • builtinNullEQStringSig
  • builtinNullEQDurationSig
  • builtinNullEQTimeSig
  • builtinNullEQJSONSig
  • builtinCaseWhenIntSig
  • builtinIfIntSig executor: go generate builtin_control_vec.go #12140
  • builtinIfNullIntSig
  • builtinUncompressedLengthSig
  • builtinFoundRowsSig
  • builtinConnectionIDSig
  • builtinLastInsertIDSig
  • builtinLastInsertIDWithIDSig
  • builtinTiDBIsDDLOwnerSig
  • builtinBenchmarkSig
  • builtinRowCountSig
  • builtinJSONContainsPathSig
  • builtinJSONContainsSig
  • builtinJSONDepthSig
  • builtinJSONLengthSig
  • builtinLikeSig
  • builtinRegexpBinarySig
  • builtinRegexpSig
  • builtinAbsIntSig
  • builtinAbsUIntSig
  • builtinRoundIntSig
  • builtinRoundWithFracIntSig
  • builtinCeilIntToIntSig
  • builtinCeilDecToIntSig
  • builtinFloorIntToIntSig
  • builtinFloorDecToIntSig
  • builtinCRC32Sig
  • builtinSignSig
  • builtinTruncateIntSig
  • builtinTruncateUintSig
  • builtinSleepSig
  • builtinLockSig
  • builtinReleaseLockSig
  • builtinIntAnyValueSig
  • builtinInetAtonSig
  • builtinIsIPv4Sig
  • builtinIsIPv4CompatSig
  • builtinIsIPv4MappedSig
  • builtinIsIPv6Sig
  • builtinNameConstIntSig
  • builtinLogicAndSig
  • builtinLogicOrSig
  • builtinLogicXorSig
  • builtinBitAndSig
  • builtinBitOrSig
  • builtinBitXorSig
  • builtinLeftShiftSig
  • builtinRightShiftSig
  • builtinRealIsTrueSig
  • builtinDecimalIsTrueSig
  • builtinIntIsTrueSig
  • builtinRealIsFalseSig
  • builtinDecimalIsFalseSig
  • builtinIntIsFalseSig
  • builtinBitNegSig
  • builtinUnaryNotRealSig
  • builtinUnaryNotDecimalSig
  • builtinUnaryNotIntSig
  • builtinUnaryMinusIntSig
  • builtinDecimalIsNullSig
  • builtinDurationIsNullSig
  • builtinIntIsNullSig
  • builtinRealIsNullSig
  • builtinStringIsNullSig @b41sh expression: implement vectorized evaluation for builtinStringIsNullSig #12128
  • builtinTimeIsNullSig
  • builtinInIntSig
  • builtinInStringSig
  • builtinInRealSig
  • builtinInDecimalSig
  • builtinInTimeSig
  • builtinInDurationSig
  • builtinInJSONSig
  • builtinBitCountSig
  • builtinLengthSig
  • builtinASCIISig
  • builtinStrcmpSig
  • builtinLocateBinary2ArgsSig
  • builtinLocate2ArgsSig
  • builtinLocateBinary3ArgsSig
  • builtinLocate3ArgsSig
  • builtinBitLengthSig
  • builtinCharLengthBinarySig
  • builtinCharLengthSig
  • builtinFindInSetSig
  • builtinFieldIntSig
  • builtinFieldRealSig
  • builtinFieldStringSig
  • builtinOrdSig
  • builtinInstrSig
  • builtinInstrBinarySig
  • builtinDateDiffSig
  • builtinHourSig
  • builtinMinuteSig
  • builtinSecondSig
  • builtinMicroSecondSig
  • builtinMonthSig @qw4990 expression: implement vectorized evaluation for builtinMonthSig  #12018
  • builtinDayNameSig
  • builtinDayOfMonthSig
  • builtinDayOfWeekSig
  • builtinDayOfYearSig
  • builtinWeekWithModeSig
  • builtinWeekWithoutModeSig
  • builtinWeekDaySig
  • builtinWeekOfYearSig
  • builtinYearSig
  • builtinYearWeekWithModeSig
  • builtinYearWeekWithoutModeSig
  • builtinExtractDatetimeSig
  • builtinExtractDurationSig
  • builtinTimestampDiffSig
  • builtinUnixTimestampCurrentSig
  • builtinUnixTimestampIntSig
  • builtinPeriodAddSig
  • builtinPeriodDiffSig
  • builtinQuarterSig
  • builtinTimeToSecSig
  • builtinToDaysSig
  • builtinToSecondsSig
@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. component/expression labels Sep 10, 2019
@qw4990 qw4990 changed the title Call For Participation: vectorize all int builtin functions Call For Participation: vectorize all Int builtin functions Sep 10, 2019
@qw4990 qw4990 mentioned this issue Sep 10, 2019
Closed
@b41sh b41sh mentioned this issue Sep 10, 2019
Merged
@tangwz
Copy link
Contributor

tangwz commented Sep 18, 2019

let me fix builtinLeastIntSig and builtinGreatestIntSig .

@k-ye k-ye mentioned this issue Sep 18, 2019
Merged
@tangwz tangwz mentioned this issue Sep 19, 2019
Merged
tangwz added a commit to tangwz/tidb that referenced this issue Sep 19, 2019
@tangwz
expression: implement vectorized evaluation for builtinGreatestIntSig (…
0c81877 
…pingcap#12103)
tangwz added a commit to tangwz/tidb that referenced this issue Sep 19, 2019
@tangwz
expression: implement vectorized evaluation for builtinLeastIntSig (p…
1fee457 
…ingcap#12103)
@tangwz tangwz mentioned this issue Sep 19, 2019
Merged
@tangwz
Copy link
Contributor

tangwz commented Sep 19, 2019

let me fix:
builtinAbsIntSig
builtinAbsUIntSig
builtinRoundIntSig
builtinRoundWithFracIntSig

@XiaTianliang
Copy link
Contributor

I want to handle
builtinArithmeticPlusIntSig

@big747386
Copy link
Contributor

let me fix:
builtinTruncateIntSig

tangwz added a commit to tangwz/tidb that referenced this issue Sep 22, 2019
@tangwz
expression: implement vectorized evaluation for builtinAbsIntSig (pin…
c25ae50 
…gcap#12103)
@tangwz tangwz mentioned this issue Sep 22, 2019
Merged
tangwz added a commit to tangwz/tidb that referenced this issue Sep 22, 2019
@tangwz
expression: implement vectorized evaluation for builtinRoundIntSig(pi…
9476fd1 
…ngcap#12103)
@tangwz tangwz mentioned this issue Sep 22, 2019
Merged
tangwz added a commit to tangwz/tidb that referenced this issue Sep 22, 2019
@tangwz
expression: implement vectorized evaluation for builtinRoundWithFracI…
ea557d6 
…ntSig (pingcap#12103)
@tangwz tangwz mentioned this issue Sep 22, 2019
Merged
tangwz added a commit to tangwz/tidb that referenced this issue Sep 23, 2019
@tangwz
expression: implement vectorized evaluation for builtinRoundWithFracI…
ff1aa5e 
…ntSig (pingcap#12103)
@lauhg lauhg mentioned this issue Sep 24, 2019
Merged
This was referenced Sep 24, 2019
Closed
Merged
@tangwz tangwz mentioned this issue Sep 25, 2019
Merged
This was referenced Sep 26, 2019
Closed
Merged
@tangwz
Copy link
Contributor

tangwz commented Sep 26, 2019

let me fix:
builtinLastInsertIDSig
builtinLastInsertIDWithIDSig
builtinCeilIntToIntSig
builtinCeilDecToIntSig
builtinFloorIntToIntSig
builtinFloorDecToIntSig

@chacha923 chacha923 mentioned this issue Nov 18, 2019
Closed
This was referenced Nov 18, 2019
Closed
Merged
Merged
Merged
@pingyu
Copy link
Contributor

pingyu commented Nov 19, 2019

Let me fix:
builtinArithmeticIntDivideDecimalSig

@pingyu pingyu mentioned this issue Nov 19, 2019
Merged
@pingyu
Copy link
Contributor

pingyu commented Nov 19, 2019

Let me fix:
builtinBenchmarkSig

@AerysNan AerysNan mentioned this issue Nov 20, 2019
Merged
@pingyu pingyu mentioned this issue Nov 20, 2019
Merged
@pingyu
Copy link
Contributor

pingyu commented Nov 20, 2019

Let me fix:
builtinLikeSig

@pingyu pingyu mentioned this issue Nov 20, 2019
Merged
@Jargon9
Copy link

Jargon9 commented Nov 22, 2019

Let me fix:
builtinReleaseLockSig

@wtianyou
Copy link

Let me fix:
builtinLockSig

@tangwz tangwz mentioned this issue Nov 27, 2019
Closed
@shihongzhi
Copy link
Member

let me fix:
builtinSleepSig

This was referenced Dec 3, 2019
Merged
Merged
Merged
@younfor
Copy link

younfor commented Dec 5, 2019

builtinBitCountSig

@younfor younfor mentioned this issue Dec 5, 2019
Closed
@chenlx0 chenlx0 mentioned this issue Dec 7, 2019
Merged
@shihongzhi shihongzhi mentioned this issue Dec 16, 2019
Closed
@ZiheLiu ZiheLiu mentioned this issue Jan 13, 2020
Merged
@ziyi-yan
Copy link
Contributor

ziyi-yan commented Mar 6, 2020

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 6, 2020

You can file a PR directly without picking up because this issue is a collection of multiple tasks. Each PR related to this issue will rewarded 50 score when merged.

@ziyi-yan ziyi-yan mentioned this issue Mar 6, 2020
Merged
@ziyi-yan
Copy link
Contributor

builtinSleepSig is done. ✅ @qw4990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests