Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinFoundRowsSig #13888

Merged
merged 3 commits into from
Dec 4, 2019
Merged

expression: implement vectorized evaluation for builtinFoundRowsSig #13888

merged 3 commits into from
Dec 4, 2019

Conversation

tangwz
Copy link
Contributor

@tangwz tangwz commented Dec 4, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinFoundRowsSig.
Issue: #12103

What is changed and how it works?

BenchmarkVectorizedBuiltinInfoFunc/builtinFoundRowsSig-VecBuiltinFunc-4                  1878369               600 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinInfoFunc/builtinFoundRowsSig-NonVecBuiltinFunc-4                 77479             15616 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@tangwz tangwz requested a review from a team as a code owner December 4, 2019 06:41
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team December 4, 2019 06:41
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 4, 2019
@codecov
Copy link

codecov bot commented Dec 4, 2019 •
edited
Loading

Codecov Report

Merging #13888 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13888   +/-   ##
===========================================
  Coverage   80.2352%   80.2352%           
===========================================
  Files           480        480           
  Lines        118838     118838           
===========================================
  Hits          95350      95350           
  Misses        15960      15960           
  Partials       7528       7528

wshwsh12
wshwsh12 reviewed Dec 4, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 4, 2019
qw4990
qw4990 approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 4, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 4, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 4, 2019

/run-all-tests

@sre-bot sre-bot merged commit bb02b70 into pingcap:master Dec 4, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@tangwz @XiaTianliang
expression: implement vectorized evaluation for builtinFoundRowsSig (…
b338dda 
…pingcap#13888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tangwz @sre-bot @qw4990 @wshwsh12