Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinLikeSig #13644

Merged
merged 2 commits into from
Nov 21, 2019
Merged

expression: implement vectorized evaluation for builtinLikeSig #13644

merged 2 commits into from
Nov 21, 2019

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Nov 20, 2019

PCP #12103

What problem does this PR solve?

Implement vectorized evaluation for builtinLikeSig at #12103

What is changed and how it works?

It gets faster about 44%.

Check List

Tests

  • Unit test
GO111MODULE=on go test -check.f TestVectorizedBuiltinLikeFunc
PASS: builtin_like_vec_test.go:35: testEvaluatorSuite.TestVectorizedBuiltinLikeFunc	0.012s
OK: 1 passed
PASS
ok  	github.com/pingcap/tidb/expression	0.038s
  • Benchmark
> go test -v -benchmem -bench=BenchmarkVectorizedBuiltinLikeFunc -run=BenchmarkVectorizedBuiltinLikeFunc -args builtinLikeSig
goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinLikeFunc/builtinLikeSig-VecBuiltinFunc-12         	   19312	     61934 ns/op	   27456 B/op	    1302 allocs/op
BenchmarkVectorizedBuiltinLikeFunc/builtinLikeSig-NonVecBuiltinFunc-12      	   13378	     88762 ns/op	   27456 B/op	    1302 allocs/op
PASS
ok  	github.com/pingcap/tidb/expression	3.949s

@pingyu pingyu requested a review from a team as a code owner November 20, 2019 17:02
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 20, 2019
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team November 20, 2019 17:02
@codecov
Copy link

codecov bot commented Nov 20, 2019 •
edited
Loading

Codecov Report

Merging #13644 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13644   +/-   ##
===========================================
  Coverage   79.9245%   79.9245%           
===========================================
  Files           473        473           
  Lines        115888     115888           
===========================================
  Hits          92623      92623           
  Misses        15968      15968           
  Partials       7297       7297

wshwsh12
wshwsh12 reviewed Nov 21, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 21, 2019
qw4990
qw4990 approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 21, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

Your auto merge job has been accepted, waiting for 13650

@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

/run-all-tests

@sre-bot sre-bot merged commit 3ad9d3b into pingcap:master Nov 21, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

@pingyu complete task #12103 and get 50 score, currerent score 350.

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@pingyu @XiaTianliang
expression: implement vectorized evaluation for builtinLikeSig (pin…
6f09b4e 
…gcap#13644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pingyu @sre-bot @qw4990 @wshwsh12