Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinLogicAndSig #12336

Merged
merged 12 commits into from
Sep 25, 2019
Merged

expression: implement vectorized evaluation for builtinLogicAndSig #12336

merged 12 commits into from
Sep 25, 2019

Conversation

lauhg
Copy link
Contributor

@lauhg lauhg commented Sep 24, 2019

What problem does this PR solve?

implement vectorized evaluation for builtinLogicAndSig
Issue: #12103

What is changed and how it works?

BenchmarkVectorizedBuiltinOpFunc/builtinLogicAndSig-VecBuiltinFunc-4         	  218979	      5192 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinOpFunc/builtinLogicAndSig-NonVecBuiltinFunc-4      	   33757	     33742 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 24, 2019
@codecov
Copy link

codecov bot commented Sep 24, 2019 •
edited
Loading

Codecov Report

Merging #12336 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12336   +/-   ##
===========================================
  Coverage   79.9113%   79.9113%           
===========================================
  Files           461        461           
  Lines        102401     102401           
===========================================
  Hits          81830      81830           
  Misses        14784      14784           
  Partials       5787       5787

Reminiscent
Reminiscent reviewed Sep 24, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2019
zz-jason
zz-jason previously approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

@lauhg merge failed.

@lauhg
Copy link
Contributor Author

lauhg commented Sep 25, 2019

/run-common-test

@qw4990
Copy link
Contributor

qw4990 commented Sep 25, 2019

/run-unit-test

@qw4990
Copy link
Contributor

qw4990 commented Sep 25, 2019

/run-all-tests

@lauhg
Copy link
Contributor Author

lauhg commented Sep 25, 2019

/run-all-tests

@Reminiscent
Copy link
Contributor

I think this kind of implementation will be more elegant, what's your opinion? @zz-jason @qw4990 @lauhg

@lauhg
Copy link
Contributor Author

lauhg commented Sep 25, 2019

I think this kind of implementation will be more elegant, what's your opinion? @zz-jason @qw4990 @lauhg

But this will introduce unnecessary computations.

ngaut
ngaut previously approved these changes Sep 25, 2019
View reviewed changes
@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

Your auto merge job has been accepted, waiting for 12386

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

@lauhg merge failed.

@zz-jason zz-jason mentioned this pull request Sep 25, 2019
Closed
@qw4990
Copy link
Contributor

qw4990 commented Sep 25, 2019

@lauhg Please solve the conflict~

@qw4990
Copy link
Contributor

qw4990 commented Sep 25, 2019

/run-unit-test

@zz-jason zz-jason merged commit e8ffaf1 into pingcap:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@qw4990 qw4990 qw4990 approved these changes

@ngaut ngaut ngaut left review comments

@zz-jason zz-jason zz-jason left review comments

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lauhg @sre-bot @qw4990 @Reminiscent @zz-jason @ngaut