Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinCastStringAsIntSig #13617

Merged
merged 6 commits into from
Nov 26, 2019
Merged

expression: implement vectorized evaluation for builtinCastStringAsIntSig #13617

merged 6 commits into from
Nov 26, 2019

Conversation

AerysNan
Copy link
Contributor

Signed-off-by: AerysNan aerysnan@gmail.com

PCP #12103

What problem does this PR solve?

Implement vectorized evaluation for builtinTidbParseTsoSig.

What is changed and how it works?

BenchmarkVectorizedBuiltinCastFunc/builtinCastStringAsIntSig-VecBuiltinFunc-4               7000            154545 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastStringAsIntSig-NonVecBuiltinFunc-4            7238            167614 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastStringAsIntSig-VecBuiltinFunc#01-4            8276            138306 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastStringAsIntSig-NonVecBuiltinFunc#01-4         7501            161245 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@AerysNan
vectorize builtinCastStringAsIntSig
278c084 
Signed-off-by: AerysNan <aerysnan@gmail.com>
@AerysNan AerysNan requested a review from a team as a code owner November 20, 2019 06:07
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 20, 2019
@ghost ghost requested review from qw4990 and SunRunAway and removed request for a team November 20, 2019 06:07
@codecov
Copy link

codecov bot commented Nov 20, 2019 •
edited
Loading

Codecov Report

Merging #13617 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13617   +/-   ##
===========================================
  Coverage   80.3454%   80.3454%           
===========================================
  Files           473        473           
  Lines        117601     117601           
===========================================
  Hits          94487      94487           
  Misses        15727      15727           
  Partials       7387       7387

SunRunAway
SunRunAway reviewed Nov 20, 2019
View reviewed changes
expression/builtin_cast_vec.go Show resolved Hide resolved
expression/builtin_cast_vec.go Outdated Show resolved Hide resolved
expression/builtin_cast_vec.go Outdated Show resolved Hide resolved
expression/builtin_cast_vec.go Show resolved Hide resolved
expression/builtin_cast_vec.go Outdated Show resolved Hide resolved
@AerysNan
fix
096cc14 
Signed-off-by: AerysNan <aerysnan@gmail.com>
SunRunAway
SunRunAway reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2019
qw4990
qw4990 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit 33b9710 into pingcap:master Nov 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2019

@AerysNan complete task #12103 and get 50 score, currerent score 550.

@AerysNan AerysNan deleted the vectorize/builtinCastStringAsIntSig branch November 27, 2019 04:00
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@AerysNan @XiaTianliang
expression: implement vectorized evaluation for `builtinCastStringAsI…
d730e2f 
…ntSig` (pingcap#13617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@qw4990 qw4990 qw4990 approved these changes

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AerysNan @sre-bot @SunRunAway @qw4990 @Reminiscent