expression: implement vectorized evaluation for builtinSleepSig
#14070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
added
component/expression
contribution
|
/rebuild |
ghost
requested review from
SunRunAway and
XuHuaiyu
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #14070 +/- ##
================================================
- Coverage 80.6472% 80.1634% -0.4838%
================================================
Files 488 483 -5
Lines 124659 121241 -3418
================================================
- Hits 100534 97191 -3343
+ Misses 16373 16307 -66
+ Partials 7752 7743 -9 |
XuHuaiyu
reviewed
Dec 16, 2019
| } | ||
| default: | ||
| if atomic.CompareAndSwapUint32(&sessVars.Killed, 1, 0) { | ||
| i64s[i] = 1 |
There was a problem hiding this comment.
We need to return here when sessVars.Killed is set to 1.
SunRunAway
reviewed
Dec 17, 2019
|
Hi, please resolve this comment #14070 (review) |
SunRunAway
reviewed
Dec 18, 2019
SunRunAway
reviewed
Dec 23, 2019
| input := chunk.New([]*types.FieldType{tp}, 1, 1) | ||
| buf := chunk.NewColumn(types.NewFieldType(mysql.TypeLonglong), 1) | ||
| da := types.Datum{} | ||
| da.SetValue(a) |
There was a problem hiding this comment.
How about add another test for three rows with three arguments of 1 second ?
| if rand.Float64() < g.nullRation { | ||
| return nil | ||
| } | ||
| return math.Floor(rand.Float64() * 10) |
There was a problem hiding this comment.
It's still too long, how about keep it in a set of [0, 0.1]?
SunRunAway
reviewed
Dec 24, 2019
| @@ -31,7 +31,7 @@ func (g *sleepTimeGener) gen() interface{} { | |||
| if rand.Float64() < g.nullRation { | |||
| return nil | |||
| } | |||
| return math.Floor(rand.Float64() * 10) | |||
| return math.Floor(rand.Float64()) | |||
There was a problem hiding this comment.
if rand.Float64() < 0.5 {
return 0
}
return 0.1
|
Hi, @shihongzhi Please fix the unit test. |
|
@shihongzhi, please update your pull request. |
1 similar comment
|
@shihongzhi, please update your pull request. |
|
@shihongzhi PR closed due to no update for a long time. Feel free to reopen it anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement vectorized evaluation for builtinSleepSig , for #12103
What is changed and how it works?
Check List
Tests