expression: implement vectorized evaluation for builtinGreatestIntSig
#12272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tangwz
force-pushed
the
fix_builtinGreatestIntSig
branch
from
2d53f8d
to
0c81877
Compare
Codecov Report
@@ Coverage Diff @@
## master #12272 +/- ##
=========================================
Coverage 81.193% 81.193%
=========================================
Files 454 454
Lines 99681 99681
=========================================
Hits 80934 80934
Misses 12946 12946
Partials 5801 5801 |
qw4990
reviewed
Sep 22, 2019
Reminiscent
reviewed
Sep 23, 2019
…stIntSig # Conflicts: # expression/builtin_compare_vec.go # expression/builtin_compare_vec_test.go
Reminiscent
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
LGTM
@tangwz Please update the branch and resolve the conflict, Thanks.
Reminiscent
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 12259 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for builtinGreatestIntSig.
Issue: #12103
What is changed and how it works?
Check List
Tests