Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for builtinReleaseLockSig #13882

Merged
merged 3 commits into from
Dec 4, 2019

Conversation

tangwz
Copy link
Contributor

@tangwz tangwz commented Dec 3, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinReleaseLockSig.
Issue: #12103

What is changed and how it works?

The release lock function will do nothing.
release_lock() function is parsed but ignored.

Check List

Tests

  • Unit test

@tangwz tangwz requested a review from a team as a code owner December 3, 2019 12:58
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team December 3, 2019 12:58
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 3, 2019
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #13882 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13882   +/-   ##
===========================================
  Coverage   80.2314%   80.2314%           
===========================================
  Files           478        478           
  Lines        118537     118537           
===========================================
  Hits          95104      95104           
  Misses        15934      15934           
  Partials       7499       7499

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2019
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 4, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 4, 2019

Your auto merge job has been accepted, waiting for 13884

@sre-bot
Copy link
Contributor

sre-bot commented Dec 4, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 4, 2019

@tangwz merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Dec 4, 2019

/run-integration-compatibility-test

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Dec 4, 2019

/run-integration-compatibility-test

@qw4990 qw4990 merged commit d2ded05 into pingcap:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants