Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinBitCountSig #13555

Closed
wants to merge 1 commit into from
Closed

expression: implement vectorized evaluation for builtinBitCountSig #13555

wants to merge 1 commit into from

Conversation

AerysNan
Copy link
Contributor

Signed-off-by: AerysNan aerysnan@gmail.com

PCP #12103

What problem does this PR solve?

Implement vectorized evaluation for builtinBitNegSig.

What is changed and how it works?

BenchmarkVectorizedBuiltinOtherFunc/builtinBitCountSig-VecBuiltinFunc-56                   31857             36541 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinOtherFunc/builtinBitCountSig-NonVecBuiltinFunc-56                15096             70084 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@AerysNan
add vectorized builtinBitCountSig
81c70c4 
Signed-off-by: AerysNan <aerysnan@gmail.com>
@AerysNan AerysNan requested a review from a team as a code owner November 18, 2019 14:16
@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 18, 2019
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team November 18, 2019 14:16
@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #13555 into master will decrease coverage by 0.0376%.
The diff coverage is 83.3333%.

@@               Coverage Diff                @@
##             master     #13555        +/-   ##
================================================
- Coverage   80.3004%   80.2627%   -0.0377%     
================================================
  Files           472        472                
  Lines        114896     114707       -189     
================================================
- Hits          92262      92067       -195     
- Misses        15413      15429        +16     
+ Partials       7221       7211        -10

wshwsh12
wshwsh12 reviewed Nov 18, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
This pr is duplicate of #13267

@AerysNan
Copy link
Contributor Author

@wshwsh12 Thanks for your reminder and I'll just close this PR. You may kindly add a reference in #13267 to #12103 or else there'll others who don't find the duplicate. 😓

@AerysNan AerysNan closed this Nov 18, 2019
@AerysNan AerysNan deleted the vectorize/builtinBitCountSig branch November 18, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AerysNan @sre-bot @wshwsh12