* Some refactoring for baselining for easy update

* Set modified time in baseline

* Some renames per feedback

…48589)

* Permit type alias variance annotations only for certain object types

* Accept new baselines

* Some refactoring of baselines

* Some refactoring of baselines

…bstitutions are consistently read (#48558)

* Ensure late painted statements are only transformed once, so inner substitutions are consistently read

* PR suggestion

* Fix lint

…on emit (#48592)

* do not flag index signatures as a control flow container

* add tests and baselines

Also baseline buildinfo so its easier to detect mistakes

* preserve this when extracting functions

* rename IsThisReferringToFunction to UsesThisInFunction

* refactor

* update tests

LEGO: Merge pull request 48612

…ame (#48496)

12 -> 14 (we have odd test errors on 12 that aren't worth debugging)

12 -> 14

12 -> 14

Update node versions

12 -> 14

12 -> 14

…union with `undefined` (#48605)

* Reuse type nodes from optional parameters and properties even when not written as a union with `undefined`

* Remove newly unneeded NodeBuilderFlag

* Update public API

* Update baselines from main

LEGO: Merge pull request 48621

LEGO: Merge pull request 48633

…ticsBuilderProgram (#48519)

* Update affected files pending emit when emitting using SemanticDignosticsBuilderProgram

* Saving of affected files pending emit is not needed any more

* PR feedback

…ersion of the file are same (#48614)

* When checking for incremental correctness always calculate signature

* Fix the issue with not serializing impliedFormat when signature == version of the file

* Variance annotations on class expressions + deferred validation

* Add regression tests

* More permissive parsing of expressions with type arguments

* Add test

* Prototype resolving to JS when go-to-def aliases all resolve to ambient declarations

* Add test infrastructure

* Start fleshing out test coverage

* Fix some go-to-def stuff

* Finish lodash test case

* Make go-to-implementation never return ambient results

* Build new functionality into go-to-implementation

* Update baselines

* Two more test cases

* Refine definition searches for unresolved imports

* Revert "Build new functionality into go-to-implementation"

This reverts commit 381799d.

* Fix tests

* Revert go-to-implementation changes

* Wow a bunch of code was unnecessary

* Update baselines and go-to-def test

* Fix navigation on symbols that are not aliases but resolve through aliases in chain

* Temporarily replace go-to-def with new command implementation

* Revert "Temporarily replace go-to-def with new command implementation"

This reverts commit 34c6cfd.

* Revert "Wow a bunch of code was unnecessary"

This reverts commit 1cb2ba6.

* Bring back some deleted code needed for a new test case

* Clean up a little

* Rename more stuff

* Update test

* Update API baseline

* Temporarily replace go-to-def with new command implementation

* PR review fixes

* Fix getTopMostDeclarationNamesInFile

* Rename local

* Use hash set

* Remove option from commandLineParser

* Keep noDtsResolution project around

* Handle AuxiliaryProject kind in ScriptInfo getDefaultProject etc.

* Do not run updateGraph in the background for AuxiliaryProject

* Don’t create auxiliary project outside of semantic mode

* No-op on scheduled invalidation

* Add comments to unit test

* Sync compiler options to auxiliary project

* Fix case sensitivity

* Update extensionIsOk with new file extensions

* PR feedback

* Update API baseline

* Mark scheduleInvalidateResolutionsOfFailedLookupLocations internal

* Use same heuristics on property accesses of loosely-resolvable aliases as unresolvable named imports

* Rename command, and no need to return the bound span

* Update API baseline

…cache. (#48579)

* Revert "Avoid no-op export map updates (#45238)"

This reverts commit 0f6e6ef.

* Need to reset currentAffectedFilesExportedModulesMap after commiting to final exports map

* Constraints for mapped types with filtering 'as' clauses

* Add regression test

…expression (#48755)

…statements and super call (#48765)

…d as referenced (#48770)

* Add test

* Ensure enum aliases referenced in other enum members do not get marked as referenced

… declarations (#48775)

…, everything needs update in signature and dts emit (#48600)

* Add test

* Renames

* More refactoring

* If we are updating dts of any of the file and it affects global scope, everything needs update in signature and dts emit
Fixes #42769

… update it with emitted d.ts file (#48616)

* If we are writing dts file and have used file text as version, we can update the signature when doing actual emit

* Make WriteFileCallback Api ready for future

* Assert that there is only single source file when emitting d.ts file

…en if they were not read (#48703)

* Use fixed time for vfs so baselining is consistent

* Baseline buildinfos

* Write new file text in baseline even if the file wasnt read on the shadow

* Remove unnecessary debugger statement

* Format snippet text before escaping

* Reset `escapes` before printing so printer can be reused

…ype (#48570)

…rload could get matched (#48811)

…ause of using wrote writeFile (#48751)

* Use fixed time for vfs so baselining is consistent

* Baseline buildinfos

* Write new file text in baseline even if the file wasnt read on the shadow

* Remove unnecessary debugger statement

* Make sure that incremental correctness is checked with correct writeFile so we know buildInfo was written
Also baseline these so its easy to verify the changes

* More baselines for the tsbuildinfo

* Renames and test fixes after dts Signature change merge

* COmment

Co-authored-by: Ron Buckton <ron.buckton@microsoft.com>

…48815)

Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>

* Improve support for numeric string types

* Update test

* Add tests

* Add Node v18 to CI

* Address comments

By copying the kludge in @typedef. @callback's order is simpler, so the
kludge is simpler. However, it's wrong here, and in @typedef. Parsing
tag comments is normally supposed to happen at the end of a tag, but in
@callback and @typedef happens *before* parsing the nested
@param/@Property tags.

I still need to figure out what a real fix is -- but for the beta,
copying the existing crash-avoidance kludge from @typedef is best
anyway. I added a test case for typedefs for future use as well.

…ype argument can't be inferred (#48533)

* change error message on Promise

* fix(46570): Unhelpful Promise type argument hint in JS file

* refactor: Reword void Promise message for JSDoc type hint to provide better feedback

Co-authored-by: Osa <osaimola@gmail.com>

…n JavaScript (#48757)

…oduleResolution node12+` (#48752)

* Add failing test

* Block auto-import module specifiers including node_modules path

* Eagerly resolve module specifiers in completions in nodenext so failures can be filtered

* Add completion info flags for telemetry

* Update API baseline

* Update completions baselines

* Fix missed boolean flip

* Fix remaining tests

Fixes #48315

* Use the same error for iterating over an Iterable in ES5 or lower.

* Accepted baselines.

…renced in @link (jsdoc) (#47824)

* Added unit test

* Added baseline test

* Dirty solution

* Code refactoring and improvements

* Added more test cases

* Refactor to use flatMap

* Added utility function to get all Nodes with JSDocs

* Minor improvements

* Use recursion to check all tree levels

* Removed unit test

* Removed previous changes

* Updated resolveEntityName call

* Updated dontResolveAlias clause

* Updated symbol flags

* Updated baseline

* Fix dont resolve alias problem

* Updated tests

…ents (#48787)

LEGO: Merge pull request 48909

LEGO: Merge pull request 48913

… inferred obj with optional members (#48910)

processChildNodes needs to skip processing when the node array is
outside the target range, just like processChildNode already does for a
single node.

Fixes #48006

* Fix jsdoc of some `DataView` method.

* Add author by 'Fix jsdoc of some `DataView` method'.

* Fix jsdoc of some `DataView` method.

change 'written' to 'read' by `getXXX` methods, and remove 'otherwise' by every method which has `littleEndian` param.

* Fix jsdoc of some `DataView` method in `es2020.bigint.d.ts`.

change 'written' to 'read' by `getXXX` methods, and remove 'otherwise' by every method which has `littleEndian` param.

…48923)

* Revert a change around allowing unconstrained type parameters to '{}'.

* Accepted baselines.

* WIP

* fix cross-project renaming logic

* only use configure if prefix opt is defined

* refactor skipAlias into stopAtAlias

* fix stopAtAlias

* update another stopAtAlias location

…8941)

* Better blocking of recursive dependencies in getNarrowedTypeOfSymbol

* Add regression test

* Remove Node12, add Node16.

* Accepted baselines.

* Refactor checking for top-level await, give a better error message in CJS files.

* Accepted baselines.

* Stop erroring on JSON module imports in node ESM since they're no longer experimental.

* Accepted baselines.

* More refactoring, do the same checks for for-await loops.

* Accepted baselines.

* Adjust phrasing to permit for-await on CJS error.

* Accepted baselines.

* Accepted baselines.

* Fix lints.