Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear ExportMapCache on cancellation requested #48979

Merged
merged 1 commit into from
May 5, 2022
Merged

Clear ExportMapCache on cancellation requested #48979

merged 1 commit into from
May 5, 2022

Conversation

andrewbranch
Copy link
Member

Almost certainly fixes #48880

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 5, 2022
andrewbranch
andrewbranch commented May 5, 2022
View reviewed changes
src/services/types.ts Outdated Show resolved Hide resolved
@andrewbranch
Copy link
Member Author

@mjbvz I bet this fixes the reliability problems you mentioned. This is most likely to affect users with large projects, which you and the folks in #48880 have in common.

@andrewbranch andrewbranch mentioned this pull request May 5, 2022
Closed
sheetalkamat
sheetalkamat requested changes May 5, 2022
View reviewed changes
src/services/exportInfoMap.ts Outdated Show resolved Hide resolved
@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 5, 2022
@andrewbranch andrewbranch merged commit 4680b54 into microsoft:main May 5, 2022
@andrewbranch andrewbranch deleted the debug-export-map-cache branch May 5, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees

@andrewbranch andrewbranch

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-import consistently failing after a few minutes (happening in vscode, nightly ts)
3 participants
@andrewbranch @sheetalkamat @typescript-bot