Fix meta property symbol lookup #48773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
weswigham
commented
Apr 19, 2022
| } | ||
| if (parent.keywordToken === SyntaxKind.NewKeyword) { | ||
| else if (isMetaProperty(parent) && parent.name === node) { | ||
| if (parent.keywordToken === SyntaxKind.NewKeyword && idText(node as Identifier) === "target") { |
There was a problem hiding this comment.
Driveby consistency fix for new.target as well - other new.whatevers no longer mistakenly have the new.target symbol (can be seen in some symbol baseline updates).
weswigham
commented
Apr 19, 2022
| @@ -11,3 +11,5 @@ | |||
| ////} | |||
|
|
|||
| verify.goToDefinition("reference", []); | |||
|
|
|||
| verify.noErrors(); | |||
There was a problem hiding this comment.
Yeah, other than the symbol baseline updates (which you could argue also showed the missing symbol problem, even if they don't call it out hard), this was all the new testing required to actually detect the issue.
andrewbranch
approved these changes
Apr 19, 2022
Jack-Works
pushed a commit
to Jack-Works/TypeScript
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48731
Our tests never caught the bug before we merged the checkers because there's no difference to goto-def between an outright missing symbol and a symbol with no declarations.