Write more useful types in .types
test outputs
#48578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42149 and #42284 improved what we display to users when presenting complex type aliases, but this had the downside of making hundreds of
.types
test outputs mostly useless, as numerous test outputs would now reportT : T
for the type of a type alias, when we were actually using those results to validate the expected type.This changes the type writer we use to generate
.types
tests to compare the stringified type to the name of the type alias and, if they match, to re-stringify the type without using its name (by passingTypeFormatFlags.InTypeAlias
totypeToString
).This change makes over a thousand individual tests across over 427
.tests
files useful again.