Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node v18 to CI #48824

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Add Node v18 to CI #48824

merged 2 commits into from
Apr 27, 2022

Conversation

ddzz
Copy link
Contributor

@ddzz ddzz commented Apr 24, 2022

This PR adds Node v18 to the CI configuration and removes Node v17. actions/setup-node has also been updated to the latest version.

Fixes #48825

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 24, 2022
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@ghost
Copy link

ghost commented Apr 24, 2022

CLA assistant check
All CLA requirements met.

@andrewbranch
Copy link
Member

IIRC we may have agreed that we want to test latest plus the last two LTS releases before that, so we would be replacing 17 here, not adding to it.

@weswigham
Copy link
Member

Yep 18 should just replace 17 as current active development version.

@ddzz
Copy link
Contributor Author

ddzz commented Apr 26, 2022

PR has been updated. The Azure pipeline needs to be updated -- it appears that this lives in a different repo?

@andrewbranch andrewbranch merged commit bab02d2 into microsoft:main Apr 27, 2022
@andrewbranch
Copy link
Member

I’ve updated the Azure Pipeline. Thanks @ddzz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test under Node v18 in CI
4 participants