Fix: verification of incremental correctness that was not working because of using wrote writeFile #48751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile so we know buildInfo was written Also baseline these so its easy to verify the changes
typescript-bot
added
Author: Team
For Uncommitted Bug
Merged
amcasey
reviewed
Apr 21, 2022
|
So the tests used to call the unpatched writeFile and that was always wrong? They were, apparently, doing this because the assert was too strict? |
amcasey
reviewed
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we use sys.writeFile for baseline buildinfo so that buildInfo correctness is verified. It was missing when we started passing the writeFileCallback which didnt track written files.
This also baselines those differences so its easy to view, read and maintain.
This is on top of #48703. Actual change is only 386786c and f45e9ca