Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more tests missing 'it' call in 'describe' #48994

Merged
merged 1 commit into from
May 6, 2022

Conversation

jakebailey
Copy link
Member

I found more of these while debugging the parser. describe calls need to have an it call in them, otherwise all of that code runs before the tests are filtered, e.g. when debugging or running a single test, which is super annoying.

I tried adding --fail-zero to our mocha thing, but it doesn't seem to catch this because it was only designed to catch when you accidentally remove every test, not when a "suite" is missing any tests. Feels like this is worth a lint rule.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 6, 2022
@jakebailey jakebailey merged commit 4765355 into microsoft:main May 6, 2022
@jakebailey jakebailey deleted the more-describe-it-oops branch May 6, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants