Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run scheduled GitHub actions on forks #48693

Merged
merged 10 commits into from
Apr 25, 2022
Merged

Don't run scheduled GitHub actions on forks #48693

merged 10 commits into from
Apr 25, 2022

Conversation

marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Apr 14, 2022

Hi,
all the GitHub actions which are run on a schedule probably don't need to run on forks. Some of them even fail to run due to missing secrets. This PR disables all scheduled actions on forks.

Please verify that:

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the main branch
  • You've successfully run gulp runtests locally
  • There are new or updated unit tests validating the change

Fixes #48694

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 14, 2022
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@jakebailey
Copy link
Member

Do we need these tasks on typescript-bot's fork?

@weswigham
Copy link
Member

weswigham commented Apr 15, 2022

Nah, don't think so. Its fork is just a safe place for it to push branches to.

@sandersn sandersn added the Housekeeping Housekeeping PRs label Apr 22, 2022
@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 22, 2022
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Let's merge this on Monday instead of right before the weekend.

@jakebailey jakebailey merged commit 42fc05b into microsoft:main Apr 25, 2022
@andrewbranch
Copy link
Member

This is a syntax error ☹️ https://github.com/microsoft/TypeScript/actions/runs/2222447002

@jakebailey
Copy link
Member

I think it's because there are two if blocks.

@marekdedic
Copy link
Contributor Author

Ah, sorry, didn't notice the other if block :/

@marekdedic marekdedic deleted the no-scheduled-gh-actions-on-forks branch April 26, 2022 11:33
@andrewbranch
Copy link
Member

No worries, at first I thought something was wrong with all of them. How does GH not automatically check PRs to their own workflow files??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug Housekeeping Housekeeping PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Don't run scheduled GitHub actions on forks
6 participants