Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle declaration file names consistently #48647

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Handle declaration file names consistently #48647

merged 1 commit into from
Apr 12, 2022

Conversation

sheetalkamat
Copy link
Member

No description provided.

weswigham
weswigham approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consolidating these all to use a single helper is great, and the tsbuild changes to handle the extra extensions at some locations probably fix something, even if offhand, I have no idea what (do they warrant a test of some kind?).

@sheetalkamat
Copy link
Member Author

There were just too many places that changed so i didnt add tests as part of this

@sheetalkamat sheetalkamat merged commit 988fa85 into main Apr 12, 2022
@sheetalkamat sheetalkamat deleted the dtsNames branch April 12, 2022 18:43
Jack-Works pushed a commit to Jack-Works/TypeScript that referenced this pull request Apr 22, 2022
@sheetalkamat @Jack-Works
Handle declaration file names consistently (microsoft#48647)
382d404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@andrewbranch andrewbranch andrewbranch approved these changes

@amcasey amcasey Awaiting requested review from amcasey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheetalkamat @weswigham @andrewbranch