Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIM Integration - Phase 1 point 0: Prepare Structures #905

Closed
3 tasks done
ralikio opened this issue Jul 3, 2024 · 5 comments
Closed
3 tasks done

KIM Integration - Phase 1 point 0: Prepare Structures #905

ralikio opened this issue Jul 3, 2024 · 5 comments
Assignees
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Comments

@ralikio
Copy link
Member

ralikio commented Jul 3, 2024

Lay ground work for #791. Create structures that prepares work for implementing Runtime CR. Additionally, during analysis of #791 we discovered unnecessary indirect dependencies that are not used in our code.

Acceptance Criteria

  • 1) Import structures - later on we can mitigate dependency
  • 2) Prepare test printing out yaml representation of created object
  • 3) Fill structure with appropriate data, write down what we data we are missing now
@ralikio ralikio added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 3, 2024
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Jul 5, 2024
@jaroslaw-pieszka jaroslaw-pieszka changed the title KIM Integration - Phase 1 point 0: Prepare Template Structures KIM Integration - Phase 1 point 0: Prepare Structures Jul 12, 2024
@jaroslaw-pieszka
Copy link
Contributor

jaroslaw-pieszka commented Jul 16, 2024

Discussion with @piotrmiskiewicz concerning setting KymaResourceName:

  • we need additional step which is called after GenerateRuntimeIDStep - when RuntimeID should have been established already
  • this step will calculate and store in operations KymaResourceName and KymaNamespace
  • this step will defensively check if RuntimeID is set on entry, returning error if not.
  • done

@jaroslaw-pieszka
Copy link
Contributor

jaroslaw-pieszka commented Jul 17, 2024

To address later on (loose ends)

  • [ ] we pass cfg.Provisioner to CreateRuntimeResource step. We need to handle this differently when Provisioner is no longer used, at least rename it, possibly merge with cfg.KimConfig as Parameter Object. In scope of KIM Integration - refactoring, decomposing CreateRuntimeResource step #1063
  • testing CreateRuntimeResource step - here we will focus with testing the logic of preparing data based on operation
  • [ ] moving the grand switch from the step to separate package - use just simple function call in the step. In scope of KIM Integration - refactoring, decomposing CreateRuntimeResource step #1063
  • add field persisting runtime resource name - as we do with Kyma name
  • implement possibility to call only KIM for selected plans - configuration setting is already prepared

@jaroslaw-pieszka
Copy link
Contributor

jaroslaw-pieszka commented Jul 18, 2024

Providers for plans:

  • Azure
  • Azure Trial
  • Azure Lite
  • AWS
  • AWS Trial
  • Preview
  • GCP
  • GCP Trial
  • Freemium Azure
  • Freemium AWS
  • sap-converged-cloud

Test coverage in step tests:

  • Azure
  • Azure Trial
  • Azure Lite
  • AWS
  • AWS Trial
  • Preview
  • GCP
  • GCP Trial
  • Freemium Azure
  • Freemium AWS
  • sap-converged-cloud

@ralikio
Copy link
Member Author

ralikio commented Jul 24, 2024

TODO:

@jaroslaw-pieszka
Copy link
Contributor

jaroslaw-pieszka commented Jul 25, 2024

Currently working on:

  • complete logic creating shoot data for all plans - in progress
  • testing it mostly on step level for all plans - in progress

Specifically working on:

  • Networking for Preview, Azure, GCP, AWS

Next steps (short-term plans):

  • Networking for Trial (AWS, GCP, Azure), Sap Converged Cloud, Free, Azure Lite
  • applying providing parameters
  • create step checking Runtime CR status
  • tackle deprovisioning

@PK85 PK85 closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

No branches or pull requests

4 participants